ash/accelerators/key_hold_detector.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/key_hold_detector.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/accelerators/key_hold_detector.cc

diff --git a/ash/accelerators/key_hold_detector.cc b/ash/accelerators/key_hold_detector.cc

index 179d4f3cb2eea734c8ba3e87bcbbf4fddf630c17..131568eaf6414f42c44375293fcf85a584d078a0 100644

--- a/ash/accelerators/key_hold_detector.cc

+++ b/ash/accelerators/key_hold_detector.cc

@@ -25,7 +25,7 @@ void DispatchPressedEvent(XEvent native_event,

if (tracker->windows().empty())

return;

aura::Window* target = *(tracker->windows().begin());

- ui::KeyEvent event(&native_event, false);

+ ui::KeyEvent event(&native_event);

event.set_flags(event.flags() | ui::EF_IS_SYNTHESIZED);

ui::EventDispatchDetails result ALLOW_UNUSED =

target->GetHost()->event_processor()->OnEventFromSource(&event);