content/browser/renderer_host/web_input_event_aura_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/web_input_event_aura_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc ('k') | content/browser/web_contents/aura/window_slider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/web_input_event_aura_unittest.cc

diff --git a/content/browser/renderer_host/web_input_event_aura_unittest.cc b/content/browser/renderer_host/web_input_event_aura_unittest.cc

index d67d0cd22780fa356b3a93d64fedcd2ce9bd5e46..15f98089fa68314611f74fdc6c0da81a9df5afa6 100644

--- a/content/browser/renderer_host/web_input_event_aura_unittest.cc

+++ b/content/browser/renderer_host/web_input_event_aura_unittest.cc

@@ -25,7 +25,7 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {

{

// Press Ctrl.

xev.InitKeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL, 0);

- ui::KeyEvent event(xev, false /* is_char */);

+ ui::KeyEvent event(xev);

blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(&event);

// However, modifier bit for Control in |webkit_event| should be set.

EXPECT_EQ(webkit_event.modifiers, blink::WebInputEvent::ControlKey);

@@ -33,7 +33,7 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEvent) {

{

// Release Ctrl.

xev.InitKeyEvent(ui::ET_KEY_RELEASED, ui::VKEY_CONTROL, ControlMask);

- ui::KeyEvent event(xev, false /* is_char */);

+ ui::KeyEvent event(xev);

blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(&event);

// However, modifier bit for Control in |webkit_event| shouldn't be set.

EXPECT_EQ(webkit_event.modifiers, 0);

@@ -50,7 +50,7 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEventWindowsKeyCode) {

xev.InitKeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL, 0);

XEvent* xevent = xev;

xevent->xkey.keycode = XKeysymToKeycode(gfx::GetXDisplay(), XK_Control_L);

- ui::KeyEvent event(xev, false /* is_char */);

+ ui::KeyEvent event(xev);

blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(&event);

// ui::VKEY_LCONTROL, instead of ui::VKEY_CONTROL, should be filled.

EXPECT_EQ(ui::VKEY_LCONTROL, webkit_event.windowsKeyCode);

@@ -60,7 +60,7 @@ TEST(WebInputEventAuraTest, TestMakeWebKeyboardEventWindowsKeyCode) {

xev.InitKeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_CONTROL, 0);

XEvent* xevent = xev;

xevent->xkey.keycode = XKeysymToKeycode(gfx::GetXDisplay(), XK_Control_R);

- ui::KeyEvent event(xev, false /* is_char */);

+ ui::KeyEvent event(xev);

blink::WebKeyboardEvent webkit_event = MakeWebKeyboardEvent(&event);

// ui::VKEY_RCONTROL, instead of ui::VKEY_CONTROL, should be filled.

EXPECT_EQ(ui::VKEY_RCONTROL, webkit_event.windowsKeyCode);