chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter_unittest.cc ('k') | chrome/browser/chromeos/input_method/input_method_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc

diff --git a/chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc b/chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc

index 20b315b69124da4b63fa65a54582ec7dc42b898d..1608924fa42b01df70d049a9b52cdfd484996e8f 100644

--- a/chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc

+++ b/chrome/browser/chromeos/events/keyboard_driven_event_rewriter_unittest.cc

@@ -23,7 +23,7 @@ class KeyboardDrivenEventRewriterTest : public testing::Test {

std::string GetRewrittenEventAsString(ui::KeyboardCode ui_keycode,

int ui_flags,

ui::EventType ui_type) {

- ui::KeyEvent keyevent(ui_type, ui_keycode, ui_flags, false);

+ ui::KeyEvent keyevent(ui_type, ui_keycode, ui_flags);

scoped_ptr<ui::Event> rewritten_event;

ui::EventRewriteStatus status =

rewriter_.RewriteForTesting(keyevent, &rewritten_event);