Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=cpu@chromium.org

Review-Url: https://codereview.chromium.org/2777063003
Cr-Commit-Position: refs/heads/master@{#463189}
Committed: https://chromium.googlesource.com/chromium/src/+/4b0c49ec412c02103e092593041c99cb69f17191

[vabr (Chromium), 2017-04-06 10:48:19]

Description was changed from

==========
Stop passing raw pointers to DictionaryValue::Set, part 3

COMMIT=false
WIP, needs some dependencies to be migrated first, in particular
components/proxy_config/proxy_config_dictionary.cc.

base::Value API has alternatives with unique_ptr, and passing ownership with
raw pointers can hide bugs. Therefore, this CL migrates a bunch of files in
//chrome/browser to use the unique_ptr-based API.

BUG=697817
==========

to

==========
Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
==========

[vabr (Chromium), 2017-04-06 11:15:56]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 11:16:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 11:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 11:41:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vabr (Chromium), 2017-04-06 12:15:21]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 12:15:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 13:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 13:00:14]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-04-06 13:11:47]

vabr@chromium.org changed reviewers:
+ atwilson@chromium.org, bauerb@chromium.org, benwells@chromium.org,
cpu@chromium.org, derat@chromium.org, dgozman@chromium.org, finnur@chromium.org,
jdoerrie@chromium.org

[vabr (Chromium), 2017-04-06 13:11:48]

Hello reviewers.

This is a mostly mechanical change. Please review as follows:

jdoerrie@ -- please review the whole patch; please see
https://crbug.com/646113#c20 for why I introduce the now-also-deprecated
CreateDeepCopy here.


atwilson@ -- please rubberstamp c/b/background
derat@ -- please rubberstamp c/b/chromeos
finnur@ -- please rubberstamp c/b/extensions and chrome/common/extensions
bauerb@ -- please rubberstamp c/b/content_settings and c/b/prefs
benwells@ -- please rubberstamp
chrome/browser/custom_handlers/protocol_handler_registry.cc
dgozman@ -- please rubberstamp c/b/devtools
cpu@ -- please rubberstamp c/b/component_updater


Thanks!
Vaclav

[Andrew T Wilson (Slow), 2017-04-06 13:13:44]

background/ LGTM

[jdoerrie, 2017-04-06 14:25:51]

Thanks a lot vabr@! Vast majority of comments are just nits, only
chrome/browser/devtools/devtools_targets_ui.cc really requires fixing.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/backgrou...
File chrome/browser/background/background_contents_service.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/backgrou...
chrome/browser/background/background_contents_service.cc:13: #include
"base/macros.h"
#include "base/memory/ptr_util.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/registry.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/registry.cc:6: 
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/registry_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/registry_unittest.cc:60: auto
file_systems = base::MakeUnique<base::DictionaryValue>();
Consider moving this down to where it's needed for the first time (ie line 91).

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/registry_unittest.cc:72: auto
watchers = base::MakeUnique<base::DictionaryValue>();
Same here.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/componen...
File
chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/componen...
chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc:6:
#include <utility>
Nit: missing new line

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_targets_ui.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_targets_ui.cc:258: parent->Set(kGuestList,
std::move(guests));
Consider renaming guests to guests_weak and guests_owned to guests to be
consistent with the other changes in this CL. In case you decide against it,
change std::move(guests) to std::move(guests_owned).

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.cc:7: #include <algorithm>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.cc:13: #include
"base/metrics/user_metrics.h"
#include "base/memory/ptr_util.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/activity_log/activity_log.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/activity_log/activity_log.cc:21: #include
"base/threading/thread_checker.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/activity_log/counting_policy_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/activity_log/counting_policy_unittest.cc:24: #include
"base/threading/thread_task_runner_handle.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc:22:
#include "base/threading/thread_task_runner_handle.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc:12:
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/autotest_private/autotest_private_api.cc:12:
#include "base/strings/string_number_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:7: #include
<math.h>  // For floor()
[[newline]]
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:12: #include
"base/strings/utf_string_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc:8: #include
"base/values.h"
 #include "base/memory/ptr_util.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service.cc:14: #include
"base/strings/utf_string_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service_browsertest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service_browsertest.cc:5:
#include "build/build_config.h"
#include <utility>

#include "base/memory/ptr_util.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:11:
#include <vector>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:16:
#include "base/message_loop/message_loop.h"
#include "base/memory/ptr_util.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:111:
auto scheme_https = base::MakeUnique<base::ListValue>();
Inline variable? This seems unused otherwise.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/font_settings/font_settings_api.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/font_settings/font_settings_api.cc:18: #include
"base/metrics/histogram_macros.h"
#include "base/memory/ptr_util.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc:15:
#include "base/memory/ptr_util.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc:17:
#include "base/memory/ptr_util.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/mdns/mdns_api_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/mdns/mdns_api_unittest.cc:13: #include
"base/memory/ptr_util.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/native_messaging_test_util.cc:7:
#include <memory>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/omnibox/omnibox_api.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:14: #include
"base/strings/utf_string_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc:9:
#include <memory>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/storage/settings_sync_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/storage/settings_sync_unittest.cc:17: #include
"base/strings/string_number_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc:8:
#include "base/memory/ptr_util.h"

#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/convert_user_script.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/convert_user_script.cc:21: #include
"base/strings/utf_string_conversions.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/convert_web_app.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/convert_web_app.cc:27: #include "base/time/time.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_assets_manager_chromeos.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_assets_manager_chromeos.cc:19: #include
"base/sys_info.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc:119:
}
Maybe drop the braces?

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_gcm_app_handler_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_gcm_app_handler_unittest.cc:7: #include
<memory>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_override_apitest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_override_apitest.cc:6: 
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_override_apitest.cc:8: #include
"build/build_config.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_prefs_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_prefs_unittest.cc:6: 
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_protocols_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_protocols_unittest.cc:8: #include <string>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:40: #include
"base/version.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_special_storage_policy_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_special_storage_policy_unittest.cc:6: 
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_web_ui.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_web_ui.cc:17: #include
"base/threading/thread_task_runner_handle.h"
#include "base/values.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/menu_manager_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/menu_manager_unittest.cc:8: #include <vector>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/webstore_inline_installer_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/webstore_inline_installer_unittest.cc:5: #include
<vector>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/prefs/tr...
File chrome/browser/prefs/tracked/pref_hash_browsertest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/prefs/tr...
chrome/browser/prefs/tracked/pref_hash_browsertest.cc:5: #include <memory>
#include <utility>

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/prefs/tr...
chrome/browser/prefs/tracked/pref_hash_browsertest.cc:15: #include
"base/metrics/histogram_samples.h"
#include "base/memory/ptr_util.h"

https://codereview.chromium.org/2777063003/diff/40001/chrome/common/extension...
File chrome/common/extensions/sync_type_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/common/extension...
chrome/common/extensions/sync_type_unittest.cc:4: 
#include <utility>

[Daniel Erat, 2017-04-06 15:03:43]

thanks! lgtm for c/b/chromeos/

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/url_util.cc (left):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/url_util.cc:97: dict->Set("extensions",
std::move(extensions_list));
hmm, this old code seems a bit odd. std::move-ing a bare pointer? or was that
from an earlier change that was done in preparation for moving the list to a
std::unique_ptr?

[Bernhard Bauer, 2017-04-06 15:21:50]

content settings and prefs LGTM

[Finnur, 2017-04-06 15:33:03]

Extensions rubberstamp LGTM

[dgozman, 2017-04-06 15:43:47]

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:1274: extension_info->Set(
nit: let's use SetString here to avoid MakeUnique boilerplate.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:1279:
extension_info->Set("name",
ditto

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:1281:
extension_info->Set("exposeExperimentalAPIs",
And SetBoolean here.

[benwells, 2017-04-07 01:58:01]

custom protocol handlers lgtm

I haven't looked at the extensions stuff at all.

[vabr (Chromium), 2017-04-07 19:54:47]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 19:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-07 20:40:41]

Thanks everyone for the amazingly fast reviews!
And in particular, to jdoerrie@ for the detailed review of the whole thing and
for finding the potential use-after-free.

dgozman@, jdoerrie@ -- I addressed your comments. Please have a look. I will
wait for both of you to approve before sending this to CQ.

Cheers,
Vaclav

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/backgrou...
File chrome/browser/background/background_contents_service.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/backgrou...
chrome/browser/background/background_contents_service.cc:13: #include
"base/macros.h"
On 2017/04/06 14:25:49, jdoerrie wrote:
> #include "base/memory/ptr_util.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_manager/url_util.cc (left):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_manager/url_util.cc:97: dict->Set("extensions",
std::move(extensions_list));
On 2017/04/06 15:03:43, Daniel Erat wrote:
> hmm, this old code seems a bit odd. std::move-ing a bare pointer? or was that
> from an earlier change that was done in preparation for moving the list to a
> std::unique_ptr?

Oops, seems like I missed that in https://codereview.chromium.org/2765363004.
Fortunately it was not worse than raw pointers and now it's finally fixed. :)
Thanks for checking this!

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/registry.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/registry.cc:6: 
On 2017/04/06 14:25:49, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/file_system_provider/registry_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/registry_unittest.cc:60: auto
file_systems = base::MakeUnique<base::DictionaryValue>();
On 2017/04/06 14:25:49, jdoerrie wrote:
> Consider moving this down to where it's needed for the first time (ie line
91).

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/file_system_provider/registry_unittest.cc:72: auto
watchers = base::MakeUnique<base::DictionaryValue>();
On 2017/04/06 14:25:49, jdoerrie wrote:
> Same here.

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/componen...
File
chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/componen...
chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc:6:
#include <utility>
On 2017/04/06 14:25:49, jdoerrie wrote:
> Nit: missing new line

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_targets_ui.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_targets_ui.cc:258: parent->Set(kGuestList,
std::move(guests));
On 2017/04/06 14:25:49, jdoerrie wrote:
> Consider renaming guests to guests_weak and guests_owned to guests to be
> consistent with the other changes in this CL. In case you decide against it,
> change std::move(guests) to std::move(guests_owned).

Oops, potential use-after-free. Thanks for catching this!

As for the naming: I started the _owned naming, then got distracted by landing
dependency CLs, and then forgot the previous naming and started to use _weak. I
will stick to _weak.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:1274: extension_info->Set(
On 2017/04/06 15:43:47, dgozman wrote:
> nit: let's use SetString here to avoid MakeUnique boilerplate.

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:1279:
extension_info->Set("name",
On 2017/04/06 15:43:47, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_ui_bindings.cc:1281:
extension_info->Set("exposeExperimentalAPIs",
On 2017/04/06 15:43:47, dgozman wrote:
> And SetBoolean here.

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.cc:7: #include <algorithm>
On 2017/04/06 14:25:49, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/devtools...
chrome/browser/devtools/devtools_window.cc:13: #include
"base/metrics/user_metrics.h"
On 2017/04/06 14:25:49, jdoerrie wrote:
> #include "base/memory/ptr_util.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/activity_log/activity_log.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/activity_log/activity_log.cc:21: #include
"base/threading/thread_checker.h"
On 2017/04/06 14:25:49, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/activity_log/counting_policy_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/activity_log/counting_policy_unittest.cc:24: #include
"base/threading/thread_task_runner_handle.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc:22:
#include "base/threading/thread_task_runner_handle.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc:12:
#include "base/strings/utf_string_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/autotest_private/autotest_private_api.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/autotest_private/autotest_private_api.cc:12:
#include "base/strings/string_number_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:7: #include
<math.h>  // For floor()
On 2017/04/06 14:25:50, jdoerrie wrote:
> [[newline]]
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc:12: #include
"base/strings/utf_string_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc:8: #include
"base/values.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
>  #include "base/memory/ptr_util.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service.cc:14: #include
"base/strings/utf_string_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/commands/command_service_browsertest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/commands/command_service_browsertest.cc:5:
#include "build/build_config.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include <utility>
> 
> #include "base/memory/ptr_util.h"
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:11:
#include <vector>
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:16:
#include "base/message_loop/message_loop.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/memory/ptr_util.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc:111:
auto scheme_https = base::MakeUnique<base::ListValue>();
On 2017/04/06 14:25:50, jdoerrie wrote:
> Inline variable? This seems unused otherwise.

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/font_settings/font_settings_api.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/font_settings/font_settings_api.cc:18: #include
"base/metrics/histogram_macros.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/memory/ptr_util.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc:15:
#include "base/memory/ptr_util.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc:17:
#include "base/memory/ptr_util.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/mdns/mdns_api_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/mdns/mdns_api_unittest.cc:13: #include
"base/memory/ptr_util.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/native_messaging_test_util.cc:7:
#include <memory>
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/omnibox/omnibox_api.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/omnibox/omnibox_api.cc:14: #include
"base/strings/utf_string_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc:9:
#include <memory>
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/storage/settings_sync_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/storage/settings_sync_unittest.cc:17: #include
"base/strings/string_number_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File
chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc:8:
#include "base/memory/ptr_util.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> 
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/convert_user_script.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/convert_user_script.cc:21: #include
"base/strings/utf_string_conversions.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/convert_web_app.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/convert_web_app.cc:27: #include "base/time/time.h"
On 2017/04/06 14:25:50, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_assets_manager_chromeos.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_assets_manager_chromeos.cc:19: #include
"base/sys_info.h"
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc:119:
}
On 2017/04/06 14:25:51, jdoerrie wrote:
> Maybe drop the braces?

The style guide says they are optional for "single-line" statements. And while
the loop body is single-line, the for-statement is not. I was never sure which
of them the style guide required to be single-line, so I have opted for the
presence of braces, which is allowed always.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_gcm_app_handler_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_gcm_app_handler_unittest.cc:7: #include
<memory>
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>
> 

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_override_apitest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_override_apitest.cc:6: 
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_override_apitest.cc:8: #include
"build/build_config.h"
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_prefs_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_prefs_unittest.cc:6: 
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>
> 

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_protocols_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_protocols_unittest.cc:8: #include <string>
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:40: #include
"base/version.h"
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_special_storage_policy_unittest.cc
(right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_special_storage_policy_unittest.cc:6: 
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_web_ui.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_web_ui.cc:17: #include
"base/threading/thread_task_runner_handle.h"
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include "base/values.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/menu_manager_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/menu_manager_unittest.cc:8: #include <vector>
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/webstore_inline_installer_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/webstore_inline_installer_unittest.cc:5: #include
<vector>
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/prefs/tr...
File chrome/browser/prefs/tracked/pref_hash_browsertest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/prefs/tr...
chrome/browser/prefs/tracked/pref_hash_browsertest.cc:5: #include <memory>
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/browser/prefs/tr...
chrome/browser/prefs/tracked/pref_hash_browsertest.cc:15: #include
"base/metrics/histogram_samples.h"
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include "base/memory/ptr_util.h"

Done.

https://codereview.chromium.org/2777063003/diff/40001/chrome/common/extension...
File chrome/common/extensions/sync_type_unittest.cc (right):

https://codereview.chromium.org/2777063003/diff/40001/chrome/common/extension...
chrome/common/extensions/sync_type_unittest.cc:4: 
On 2017/04/06 14:25:51, jdoerrie wrote:
> #include <utility>

Done.

[commit-bot: I haz the power, 2017-04-07 20:43:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 20:43:35]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-07 20:59:27]

devtools lgtm, thank you!

[jdoerrie, 2017-04-10 06:48:08]

LGTM, thanks!

[vabr (Chromium), 2017-04-10 06:49:40]

Description was changed from

==========
Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
==========

to

==========
Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=cpu@chromium.org
==========

[vabr (Chromium), 2017-04-10 06:51:53]

Thanks!

I'm putting cpu@ in TBR for c/b/component_updater and sending this to the CQ.

Cheers,
Vaclav

[vabr (Chromium), 2017-04-10 06:52:05]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-04-10 06:52:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
finnur@chromium.org, benwells@chromium.org, derat@chromium.org,
atwilson@chromium.org
Link to the patchset: https://codereview.chromium.org/2777063003/#ps60001
(title: "Comments")

[commit-bot: I haz the power, 2017-04-10 06:52:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 06:56:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 06:56:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[vabr (Chromium), 2017-04-10 07:16:11]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-04-10 07:16:12]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
finnur@chromium.org, benwells@chromium.org, derat@chromium.org,
atwilson@chromium.org, jdoerrie@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2777063003/#ps80001
(title: "Just rebased")

[commit-bot: I haz the power, 2017-04-10 07:16:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 08:07:46]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491808571670970,
"parent_rev": "0bd89391dc79ae15c314d632f5829b0d430cf9af", "commit_rev":
"4b0c49ec412c02103e092593041c99cb69f17191"}

[commit-bot: I haz the power, 2017-04-10 08:08:35]

Description was changed from

==========
Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=cpu@chromium.org
==========

to

==========
Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Passing ownership of base::Value into API methods DictionaryValue::Set,
DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
pointers is deprecated, can hide bugs and should be done via unique_ptr
instead.

Therefore, this CL migrates c/b/chromeos, c/b/extensions and a bunch of related
files to use the unique_ptr-based API.

BUG=697817
TBR=cpu@chromium.org

Review-Url: https://codereview.chromium.org/2777063003
Cr-Commit-Position: refs/heads/master@{#463189}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b0c49ec412c02103e092593041c...
==========

[commit-bot: I haz the power, 2017-04-10 08:08:37]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/4b0c49ec412c02103e092593041c...

[findit-for-me, 2017-04-10 09:01:27]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2806283002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit identified CL at revision 463189 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[jdoerrie, 2017-04-10 10:39:23]

https://codereview.chromium.org/2777063003/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/api/proxy/proxy_api.cc (right):

https://codereview.chromium.org/2777063003/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/api/proxy/proxy_api.cc:192: return extension_pref;
return std::move(extension_pref); should fix the compilation error for
ChromiumOS x86-generic