Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/extension_management_test_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_management_test_util.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 31 matching lines @@
 
 void ExtensionManagementPrefUpdaterBase::UnsetPerExtensionSettings(
     const ExtensionId& id) {
   DCHECK(crx_file::id_util::IdIsValid(id));
   pref_->RemoveWithoutPathExpansion(id, nullptr);
 }
 
 void ExtensionManagementPrefUpdaterBase::ClearPerExtensionSettings(
     const ExtensionId& id) {
   DCHECK(crx_file::id_util::IdIsValid(id));
-  pref_->SetWithoutPathExpansion(id, new base::DictionaryValue());
+  pref_->SetWithoutPathExpansion(id, base::MakeUnique<base::DictionaryValue>());
 }
 
 // Helper functions for 'installation_mode' manipulation -----------------------
 
 void ExtensionManagementPrefUpdaterBase::SetBlacklistedByDefault(bool value) {
   pref_->SetString(make_path(schema::kWildcard, schema::kInstallationMode),
                    value ? schema::kBlocked : schema::kAllowed);
 }
 
 void ExtensionManagementPrefUpdaterBase::
@@ skipping 152 matching lines @@
 void ExtensionManagementPrefUpdaterBase::SetPref(base::DictionaryValue* pref) {
   pref_.reset(pref);
 }
 
 std::unique_ptr<base::DictionaryValue>
 ExtensionManagementPrefUpdaterBase::TakePref() {
   return std::move(pref_);
 }
 
 void ExtensionManagementPrefUpdaterBase::ClearList(const std::string& path) {
-  pref_->Set(path, new base::ListValue());
+  pref_->Set(path, base::MakeUnique<base::ListValue>());
 }
 
 void ExtensionManagementPrefUpdaterBase::AddStringToList(
     const std::string& path,
     const std::string& str) {
-  base::ListValue* list_value = nullptr;
-  if (!pref_->GetList(path, &list_value)) {
-    list_value = new base::ListValue();
-    pref_->Set(path, list_value);
+  base::ListValue* list_value_weak = nullptr;
+  if (!pref_->GetList(path, &list_value_weak)) {
+    auto list_value = base::MakeUnique<base::ListValue>();
+    list_value_weak = list_value.get();
+    pref_->Set(path, std::move(list_value));
   }
-  CHECK(list_value->AppendIfNotPresent(base::MakeUnique<base::Value>(str)));
+  CHECK(
+      list_value_weak->AppendIfNotPresent(base::MakeUnique<base::Value>(str)));
 }
 
 void ExtensionManagementPrefUpdaterBase::RemoveStringFromList(
     const std::string& path,
     const std::string& str) {
   base::ListValue* list_value = nullptr;
   if (pref_->GetList(path, &list_value))
     CHECK(list_value->Remove(base::Value(str), nullptr));
 }
 
@@ skipping 18 matching lines @@
   policies_
       ->Get(
           policy::PolicyNamespace(policy::POLICY_DOMAIN_CHROME, std::string()))
       .Set(policy::key::kExtensionSettings, policy::POLICY_LEVEL_MANDATORY,
            policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, TakePref(),
            nullptr);
   provider_->UpdatePolicy(std::move(policies_));
 }
 
 }  // namespace extensions