Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_garbage_collector_chromeos.h"
 
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/files/file_util.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/extensions/extension_assets_manager_chromeos.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
@@ skipping 70 matching lines @@
     return path;
   }
 
   void CreateSharedExtensionPrefs(const std::string& id,
                                   const std::string& version,
                                   const std::string& users_string,
                                   const base::FilePath& path) {
     DictionaryPrefUpdate shared_extensions(testing_local_state_.Get(),
         ExtensionAssetsManagerChromeOS::kSharedExtensions);
 
-    base::DictionaryValue* extension_info = NULL;
-    if (!shared_extensions->GetDictionary(id, &extension_info)) {
-      extension_info = new base::DictionaryValue;
-      shared_extensions->Set(id, extension_info);
+    base::DictionaryValue* extension_info_weak = NULL;
+    if (!shared_extensions->GetDictionary(id, &extension_info_weak)) {
+      auto extension_info = base::MakeUnique<base::DictionaryValue>();
+      extension_info_weak = extension_info.get();
+      shared_extensions->Set(id, std::move(extension_info));
     }
 
-    base::DictionaryValue* version_info = new base::DictionaryValue;
-    extension_info->SetWithoutPathExpansion(version, version_info);
+    auto version_info = base::MakeUnique<base::DictionaryValue>();
     version_info->SetString(
         ExtensionAssetsManagerChromeOS::kSharedExtensionPath, path.value());
 
-    base::ListValue* users = new base::ListValue;
+    auto users = base::MakeUnique<base::ListValue>();
+    for (const std::string& user :
+         base::SplitString(users_string, ",", base::KEEP_WHITESPACE,
+                           base::SPLIT_WANT_NONEMPTY)) {
+      users->AppendString(user);
+    }

[jdoerrie, 2017/04/06 14:25:51]

Maybe drop the braces?

[vabr (Chromium), 2017/04/07 20:40:40]

The style guide says they are optional for "single-line" statements. And while
the loop body is single-line, the for-statement is not. I was never sure which
of them the style guide required to be single-line, so I have opted for the
presence of braces, which is allowed always.

     version_info->Set(ExtensionAssetsManagerChromeOS::kSharedExtensionUsers,
-                      users);
-    for (const std::string& user :
-         base::SplitString(users_string, ",",
-                           base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY))
-      users->AppendString(user);
+                      std::move(users));
+    extension_info_weak->SetWithoutPathExpansion(version,
+                                                 std::move(version_info));
   }
 
   scoped_refptr<Extension> CreateExtension(const std::string& id,
                                            const std::string& version,
                                            const base::FilePath& path) {
     base::DictionaryValue manifest;
     manifest.SetString(manifest_keys::kName, "test");
     manifest.SetString(manifest_keys::kVersion, version);
 
     std::string error;
@@ skipping 62 matching lines @@
 
   const base::DictionaryValue* shared_extensions = testing_local_state_.Get()->
       GetDictionary(ExtensionAssetsManagerChromeOS::kSharedExtensions);
   ASSERT_TRUE(shared_extensions);
 
   EXPECT_FALSE(shared_extensions->HasKey(kExtensionId1));
   EXPECT_TRUE(shared_extensions->HasKey(kExtensionId2));
 }
 
 }  // namespace extensions