Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/chromeos/file_manager/url_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/url_util.h"
 
 #include <stddef.h>
 
 #include "base/json/json_writer.h"
 #include "base/memory/ptr_util.h"
@@ skipping 70 matching lines @@
   arg_value.SetString("type", GetDialogTypeAsString(type));
   arg_value.SetString("title", title);
   arg_value.SetString("currentDirectoryURL", current_directory_url.spec());
   arg_value.SetString("selectionURL", selection_url.spec());
   arg_value.SetString("targetName", target_name);
   arg_value.SetString("defaultExtension", default_extension);
 
   if (file_types) {
     auto types_list = base::MakeUnique<base::ListValue>();
     for (size_t i = 0; i < file_types->extensions.size(); ++i) {
-      base::ListValue* extensions_list = new base::ListValue();
+      auto extensions_list = base::MakeUnique<base::ListValue>();
       for (size_t j = 0; j < file_types->extensions[i].size(); ++j) {
         extensions_list->AppendString(file_types->extensions[i][j]);
       }
 
       auto dict = base::MakeUnique<base::DictionaryValue>();
       dict->Set("extensions", std::move(extensions_list));

[Daniel Erat, 2017/04/06 15:03:43]

hmm, this old code seems a bit odd. std::move-ing a bare pointer? or was that
from an earlier change that was done in preparation for moving the list to a
std::unique_ptr?

[vabr (Chromium), 2017/04/07 20:40:39]

Oops, seems like I missed that in https://codereview.chromium.org/2765363004.
Fortunately it was not worse than raw pointers and now it's finally fixed. :)
Thanks for checking this!

 
       if (i < file_types->extension_description_overrides.size()) {
         base::string16 desc = file_types->extension_description_overrides[i];
         dict->SetString("description", desc);
       }
 
       // file_type_index is 1-based. 0 means no selection at all.
       dict->SetBoolean("selected",
                        (static_cast<size_t>(file_type_index) == (i + 1)));
 
@@ skipping 26 matching lines @@
   base::JSONWriter::Write(arg_value, &json_args);
 
   std::string url = GetFileManagerMainPageUrl().spec() + '?' +
       net::EscapeUrlEncodedData(json_args,
                                 false);  // Space to %20 instead of +.
   return GURL(url);
 }
 
 }  // namespace util
 }  // namespace file_manager