Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h"
 
 #include "base/logging.h"
+#include "base/memory/ptr_util.h"

[jdoerrie, 2017/04/06 14:25:50]

#include "base/values.h"

[vabr (Chromium), 2017/04/07 20:40:40]

Done.

 #include "storage/browser/fileapi/file_system_url.h"
 #include "storage/common/fileapi/file_system_util.h"
 
 namespace extensions {
 
 api::sync_file_system::ServiceStatus SyncServiceStateToExtensionEnum(
     sync_file_system::SyncServiceState state) {
   switch (state) {
     case sync_file_system::SYNC_SERVICE_RUNNING:
       return api::sync_file_system::SERVICE_STATUS_RUNNING;
@@ skipping 80 matching lines @@
     case sync_file_system::CONFLICT_RESOLUTION_POLICY_MANUAL:
       return api::sync_file_system::CONFLICT_RESOLUTION_POLICY_MANUAL;
     case sync_file_system::CONFLICT_RESOLUTION_POLICY_MAX:
       NOTREACHED();
       return api::sync_file_system::CONFLICT_RESOLUTION_POLICY_NONE;
   }
   NOTREACHED() << "Invalid conflict resolution policy: " << policy;
   return api::sync_file_system::CONFLICT_RESOLUTION_POLICY_NONE;
 }
 
-base::DictionaryValue* CreateDictionaryValueForFileSystemEntry(
+std::unique_ptr<base::DictionaryValue> CreateDictionaryValueForFileSystemEntry(
     const storage::FileSystemURL& url,
     sync_file_system::SyncFileType file_type) {
   if (!url.is_valid() || file_type == sync_file_system::SYNC_FILE_TYPE_UNKNOWN)
-    return NULL;
+    return nullptr;
 
   std::string file_path =
       base::FilePath(storage::VirtualPath::GetNormalizedFilePath(url.path()))
           .AsUTF8Unsafe();
 
   std::string root_url =
       storage::GetFileSystemRootURI(url.origin(), url.mount_type()).spec();
   if (!url.filesystem_id().empty()) {
     root_url.append(url.filesystem_id());
     root_url.append("/");
   }
 
-  base::DictionaryValue* dict = new base::DictionaryValue;
+  auto dict = base::MakeUnique<base::DictionaryValue>();
   dict->SetString("fileSystemType",
                   storage::GetFileSystemTypeString(url.mount_type()));
   dict->SetString("fileSystemName",
                   storage::GetFileSystemName(url.origin(), url.type()));
   dict->SetString("rootUrl", root_url);
   dict->SetString("filePath", file_path);
   dict->SetBoolean("isDirectory",
                    (file_type == sync_file_system::SYNC_FILE_TYPE_DIRECTORY));
 
   return dict;
 }
 
 }  // namespace extensions