Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
+#include <utility>

[jdoerrie, 2017/04/06 14:25:49]

Nit: missing new line

[vabr (Chromium), 2017/04/07 20:40:39]

Done.

 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 213 matching lines @@
     ASSERT_TRUE(
         PathService::Get(chrome::DIR_SUPERVISED_USER_INSTALLED_WHITELISTS,
                          &installed_whitelist_directory_));
     std::string crx_id(kCrxId);
     whitelist_path_ =
         installed_whitelist_directory_.AppendASCII(crx_id + ".json");
 
     std::unique_ptr<base::DictionaryValue> whitelist_dict(
         new base::DictionaryValue);
     whitelist_dict->SetString("sites", kWhitelistFile);
-    manifest_.Set("whitelisted_content", whitelist_dict.release());
+    manifest_.Set("whitelisted_content", std::move(whitelist_dict));
 
     large_icon_path_ = whitelist_version_directory_.AppendASCII(kLargeIconFile);
     std::unique_ptr<base::DictionaryValue> icons_dict(
         new base::DictionaryValue);
     icons_dict->SetString("128", kLargeIconFile);
-    manifest_.Set("icons", icons_dict.release());
+    manifest_.Set("icons", std::move(icons_dict));
 
     manifest_.SetString("version", kVersion);
 
     std::unique_ptr<base::DictionaryValue> crx_dict(new base::DictionaryValue);
     crx_dict->SetString("name", kName);
     std::unique_ptr<base::ListValue> clients(new base::ListValue);
     clients->AppendString(kClientId);
     clients->AppendString(kOtherClientId);
-    crx_dict->Set("clients", clients.release());
-    pref_.Set(kCrxId, crx_dict.release());
+    crx_dict->Set("clients", std::move(clients));
+    pref_.Set(kCrxId, std::move(crx_dict));
   }
 
  protected:
   ProfileAttributesStorage* profile_attributes_storage() {
     return testing_profile_manager_.profile_attributes_storage();
   }
 
   base::FilePath GetProfilePath(const std::string& profile_name) {
     return testing_profile_manager_.profiles_dir().AppendASCII(profile_name);
   }
@@ skipping 159 matching lines @@
     // but it exercises a different code path.
     profile_attributes_storage()->RemoveProfile(GetProfilePath(kOtherClientId));
     run_loop.RunUntilIdle();
   }
   EXPECT_FALSE(component_update_service_.registered_component());
   EXPECT_FALSE(base::DirectoryExists(whitelist_directory_));
   EXPECT_FALSE(base::PathExists(whitelist_path_));
 }
 
 }  // namespace component_updater