Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc b/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
index 75fe94389b045de166f0f61490b259dd494cd841..b841d5f5f9d05b8d11645f485e52169c85b5bcbc 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmark_apitest.cc
@@ -5,6 +5,7 @@
#include <memory>
#include <utility>
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
@@ -44,7 +45,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) {
list.Append(std::move(node));
node.reset(new base::DictionaryValue());
node->SetString("name", "Managed Folder");
- node->Set("children", new base::ListValue());
+ node->Set("children", base::MakeUnique<base::ListValue>());
list.Append(std::move(node));
profile->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list);
ASSERT_EQ(2, managed->managed_node()->child_count());
@@ -58,7 +59,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_Bookmarks) {
list.Append(std::move(node));
node.reset(new base::DictionaryValue());
node->SetString("name", "Supervised Folder");
- node->Set("children", new base::ListValue());
+ node->Set("children", base::MakeUnique<base::ListValue>());
list.Append(std::move(node));
profile->GetPrefs()->Set(bookmarks::prefs::kSupervisedBookmarks, list);
ASSERT_EQ(2, managed->supervised_node()->child_count());

Powered by Google App Engine
This is Rietveld 408576698