OLD | NEW |
---|---|
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/extensions/menu_manager.h" | 5 #include "chrome/browser/extensions/menu_manager.h" |
6 | 6 |
7 #include <memory> | 7 #include <memory> |
8 #include <vector> | 8 #include <vector> |
jdoerrie
2017/04/06 14:25:51
#include <utility>
vabr (Chromium)
2017/04/07 20:40:41
Done.
| |
9 | 9 |
10 #include "base/files/scoped_temp_dir.h" | 10 #include "base/files/scoped_temp_dir.h" |
11 #include "base/json/json_reader.h" | 11 #include "base/json/json_reader.h" |
12 #include "base/macros.h" | 12 #include "base/macros.h" |
13 #include "base/memory/ptr_util.h" | 13 #include "base/memory/ptr_util.h" |
14 #include "base/run_loop.h" | 14 #include "base/run_loop.h" |
15 #include "base/strings/utf_string_conversions.h" | 15 #include "base/strings/utf_string_conversions.h" |
16 #include "base/threading/thread_task_runner_handle.h" | 16 #include "base/threading/thread_task_runner_handle.h" |
17 #include "base/values.h" | 17 #include "base/values.h" |
18 #include "chrome/browser/chrome_notification_types.h" | 18 #include "chrome/browser/chrome_notification_types.h" |
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
224 int type = MenuItem::CHECKBOX; | 224 int type = MenuItem::CHECKBOX; |
225 std::string title("TITLE"); | 225 std::string title("TITLE"); |
226 bool checked = true; | 226 bool checked = true; |
227 bool enabled = true; | 227 bool enabled = true; |
228 MenuItem::ContextList contexts; | 228 MenuItem::ContextList contexts; |
229 contexts.Add(MenuItem::PAGE); | 229 contexts.Add(MenuItem::PAGE); |
230 contexts.Add(MenuItem::SELECTION); | 230 contexts.Add(MenuItem::SELECTION); |
231 int contexts_value = 0; | 231 int contexts_value = 0; |
232 ASSERT_TRUE(contexts.ToValue()->GetAsInteger(&contexts_value)); | 232 ASSERT_TRUE(contexts.ToValue()->GetAsInteger(&contexts_value)); |
233 | 233 |
234 base::ListValue* document_url_patterns(new base::ListValue()); | 234 auto document_url_patterns = base::MakeUnique<base::ListValue>(); |
235 document_url_patterns->AppendString("http://www.google.com/*"); | 235 document_url_patterns->AppendString("http://www.google.com/*"); |
236 document_url_patterns->AppendString("http://www.reddit.com/*"); | 236 document_url_patterns->AppendString("http://www.reddit.com/*"); |
237 | 237 |
238 base::ListValue* target_url_patterns(new base::ListValue()); | 238 auto target_url_patterns = base::MakeUnique<base::ListValue>(); |
239 target_url_patterns->AppendString("http://www.yahoo.com/*"); | 239 target_url_patterns->AppendString("http://www.yahoo.com/*"); |
240 target_url_patterns->AppendString("http://www.facebook.com/*"); | 240 target_url_patterns->AppendString("http://www.facebook.com/*"); |
241 | 241 |
242 base::DictionaryValue value; | 242 base::DictionaryValue value; |
243 value.SetBoolean("incognito", incognito); | 243 value.SetBoolean("incognito", incognito); |
244 value.SetString("string_uid", std::string()); | 244 value.SetString("string_uid", std::string()); |
245 value.SetInteger("type", type); | 245 value.SetInteger("type", type); |
246 value.SetString("title", title); | 246 value.SetString("title", title); |
247 value.SetBoolean("checked", checked); | 247 value.SetBoolean("checked", checked); |
248 value.SetBoolean("enabled", enabled); | 248 value.SetBoolean("enabled", enabled); |
249 value.SetInteger("contexts", contexts_value); | 249 value.SetInteger("contexts", contexts_value); |
250 value.Set("document_url_patterns", document_url_patterns); | 250 std::string error; |
251 value.Set("target_url_patterns", target_url_patterns); | 251 URLPatternSet document_url_pattern_set; |
252 document_url_pattern_set.Populate(*document_url_patterns, | |
253 URLPattern::SCHEME_ALL, true, &error); | |
254 value.Set("document_url_patterns", std::move(document_url_patterns)); | |
255 URLPatternSet target_url_pattern_set; | |
256 target_url_pattern_set.Populate(*target_url_patterns, URLPattern::SCHEME_ALL, | |
257 true, &error); | |
258 value.Set("target_url_patterns", std::move(target_url_patterns)); | |
252 | 259 |
253 std::string error; | |
254 std::unique_ptr<MenuItem> item( | 260 std::unique_ptr<MenuItem> item( |
255 MenuItem::Populate(extension->id(), value, &error)); | 261 MenuItem::Populate(extension->id(), value, &error)); |
256 ASSERT_TRUE(item.get()); | 262 ASSERT_TRUE(item.get()); |
257 | 263 |
258 EXPECT_EQ(extension->id(), item->extension_id()); | 264 EXPECT_EQ(extension->id(), item->extension_id()); |
259 EXPECT_EQ(incognito, item->incognito()); | 265 EXPECT_EQ(incognito, item->incognito()); |
260 EXPECT_EQ(title, item->title()); | 266 EXPECT_EQ(title, item->title()); |
261 EXPECT_EQ(checked, item->checked()); | 267 EXPECT_EQ(checked, item->checked()); |
262 EXPECT_EQ(item->checked(), item->checked()); | 268 EXPECT_EQ(item->checked(), item->checked()); |
263 EXPECT_EQ(enabled, item->enabled()); | 269 EXPECT_EQ(enabled, item->enabled()); |
264 EXPECT_EQ(contexts, item->contexts()); | 270 EXPECT_EQ(contexts, item->contexts()); |
265 | 271 |
266 URLPatternSet document_url_pattern_set; | |
267 document_url_pattern_set.Populate(*document_url_patterns, | |
268 URLPattern::SCHEME_ALL, | |
269 true, | |
270 &error); | |
271 EXPECT_EQ(document_url_pattern_set, item->document_url_patterns()); | 272 EXPECT_EQ(document_url_pattern_set, item->document_url_patterns()); |
272 | 273 |
273 URLPatternSet target_url_pattern_set; | |
274 target_url_pattern_set.Populate(*target_url_patterns, | |
275 URLPattern::SCHEME_ALL, | |
276 true, | |
277 &error); | |
278 EXPECT_EQ(target_url_pattern_set, item->target_url_patterns()); | 274 EXPECT_EQ(target_url_pattern_set, item->target_url_patterns()); |
279 } | 275 } |
280 | 276 |
281 // Tests that deleting a parent properly removes descendants. | 277 // Tests that deleting a parent properly removes descendants. |
282 TEST_F(MenuManagerTest, DeleteParent) { | 278 TEST_F(MenuManagerTest, DeleteParent) { |
283 Extension* extension = AddExtension("1111"); | 279 Extension* extension = AddExtension("1111"); |
284 | 280 |
285 // Set up 5 items to add. | 281 // Set up 5 items to add. |
286 std::unique_ptr<MenuItem> item1 = CreateTestItem(extension); | 282 std::unique_ptr<MenuItem> item1 = CreateTestItem(extension); |
287 std::unique_ptr<MenuItem> item2 = CreateTestItem(extension); | 283 std::unique_ptr<MenuItem> item2 = CreateTestItem(extension); |
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
772 EXPECT_EQ(4u, manager_.MenuItems(key1)->size()); | 768 EXPECT_EQ(4u, manager_.MenuItems(key1)->size()); |
773 EXPECT_EQ(1u, manager_.MenuItems(key2)->size()); | 769 EXPECT_EQ(1u, manager_.MenuItems(key2)->size()); |
774 | 770 |
775 // Remove all context menu items with incognito true. | 771 // Remove all context menu items with incognito true. |
776 manager_.RemoveAllIncognitoContextItems(); | 772 manager_.RemoveAllIncognitoContextItems(); |
777 EXPECT_EQ(2u, manager_.MenuItems(key1)->size()); | 773 EXPECT_EQ(2u, manager_.MenuItems(key1)->size()); |
778 EXPECT_EQ(1u, manager_.MenuItems(key2)->size()); | 774 EXPECT_EQ(1u, manager_.MenuItems(key2)->size()); |
779 } | 775 } |
780 | 776 |
781 } // namespace extensions | 777 } // namespace extensions |
OLD | NEW |