Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/devtools/devtools_ui_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 1081 matching lines @@
   base::Value message_value(message);
   callback.Run(&message_value);
 }
 
 void DevToolsUIBindings::OnURLFetchComplete(const net::URLFetcher* source) {
   DCHECK(source);
   PendingRequestsMap::iterator it = pending_requests_.find(source);
   DCHECK(it != pending_requests_.end());
 
   base::DictionaryValue response;
-  base::DictionaryValue* headers = new base::DictionaryValue();
+  auto headers = base::MakeUnique<base::DictionaryValue>();
   net::HttpResponseHeaders* rh = source->GetResponseHeaders();
   response.SetInteger("statusCode", rh ? rh->response_code() : 200);
-  response.Set("headers", headers);
 
   size_t iterator = 0;
   std::string name;
   std::string value;
   while (rh && rh->EnumerateHeaderLines(&iterator, &name, &value))
     headers->SetString(name, value);
 
+  response.Set("headers", std::move(headers));
   it->second.Run(&response);
   pending_requests_.erase(it);
   delete source;
 }
 
 void DevToolsUIBindings::DeviceCountChanged(int count) {
   base::Value value(count);
   CallClientFunction("DevToolsAPI.deviceCountUpdated", &value, NULL,
                      NULL);
 }
@@ skipping 141 matching lines @@
 
     // Each devtools extension will need to be able to run in the devtools
     // process. Grant each specific extension's origin permission to load
     // documents.
     content::ChildProcessSecurityPolicy::GetInstance()->GrantOrigin(
         web_contents_->GetMainFrame()->GetProcess()->GetID(),
         url::Origin(extension->url()));
 
     std::unique_ptr<base::DictionaryValue> extension_info(
         new base::DictionaryValue());
     extension_info->Set(

[dgozman, 2017/04/06 15:43:47]

nit: let's use SetString here to avoid MakeUnique boilerplate.

[vabr (Chromium), 2017/04/07 20:40:39]

Done.

         "startPage",
-        new base::Value(
+        base::MakeUnique<base::Value>(
             extensions::chrome_manifest_urls::GetDevToolsPage(extension.get())
                 .spec()));
-    extension_info->Set("name", new base::Value(extension->name()));
-    extension_info->Set(
-        "exposeExperimentalAPIs",
-        new base::Value(extension->permissions_data()->HasAPIPermission(
-            extensions::APIPermission::kExperimental)));
+    extension_info->Set("name",

[dgozman, 2017/04/06 15:43:47]

ditto

[vabr (Chromium), 2017/04/07 20:40:39]

Done.

+                        base::MakeUnique<base::Value>(extension->name()));
+    extension_info->Set("exposeExperimentalAPIs",

[dgozman, 2017/04/06 15:43:47]

And SetBoolean here.

[vabr (Chromium), 2017/04/07 20:40:39]

Done.

+                        base::MakeUnique<base::Value>(
+                            extension->permissions_data()->HasAPIPermission(
+                                extensions::APIPermission::kExperimental)));
     results.Append(std::move(extension_info));
   }
 
   CallClientFunction("DevToolsAPI.addExtensions",
                      &results, NULL, NULL);
 }
 
 void DevToolsUIBindings::SetDelegate(Delegate* delegate) {
   delegate_.reset(delegate);
 }
@@ skipping 75 matching lines @@
 void DevToolsUIBindings::FrontendLoaded() {
   if (frontend_loaded_)
     return;
   frontend_loaded_ = true;
 
   // Call delegate first - it seeds importants bit of information.
   delegate_->OnLoadCompleted();
 
   AddDevToolsExtensionsToClient();
 }