Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/activity_log/activity_log.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/activity_log.h"
 
 #include <stddef.h>
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/threading/thread_checker.h"

[jdoerrie, 2017/04/06 14:25:49]

#include "base/values.h"

[vabr (Chromium), 2017/04/07 20:40:39]

Done.

 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/activity_log/activity_action_constants.h"
 #include "chrome/browser/extensions/activity_log/counting_policy.h"
 #include "chrome/browser/extensions/activity_log/fullstream_ui_policy.h"
 #include "chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 239 matching lines @@
   bool arg_incognito = action->page_incognito();
 
   switch (api_info->arg_url_transform) {
     case NONE: {
       // No translation needed; just extract the URL directly from a raw string
       // or from a dictionary.  Succeeds if we can find a string in the
       // argument list and that the string resolves to a valid URL.
       std::string url_string;
       if (action->args()->GetString(url_index, &url_string) &&
           ResolveUrl(action->page_url(), url_string, &arg_url)) {
-        action->mutable_args()->Set(url_index,
-                                    new base::Value(kArgUrlPlaceholder));
+        action->mutable_args()->Set(
+            url_index, base::MakeUnique<base::Value>(kArgUrlPlaceholder));
       }
       break;
     }
 
     case DICT_LOOKUP: {
       CHECK(api_info->arg_url_dict_path);
       // Look up the URL from a dictionary at the specified location.  Succeeds
       // if we can find a dictionary in the argument list, the dictionary
       // contains the specified key, and the corresponding value resolves to a
       // valid URL.
@@ skipping 10 matching lines @@
     case LOOKUP_TAB_ID: {
       // Translation of tab IDs to URLs has been requested.  There are two
       // cases to consider: either a single integer or a list of integers (when
       // multiple tabs are manipulated).
       int tab_id;
       base::ListValue* tab_list = NULL;
       if (action->args()->GetInteger(url_index, &tab_id)) {
         // Single tab ID to translate.
         GetUrlForTabId(tab_id, profile, &arg_url, &arg_incognito);
         if (arg_url.is_valid()) {
-          action->mutable_args()->Set(url_index,
-                                      new base::Value(kArgUrlPlaceholder));
+          action->mutable_args()->Set(
+              url_index, base::MakeUnique<base::Value>(kArgUrlPlaceholder));
         }
       } else if (action->mutable_args()->GetList(url_index, &tab_list)) {
         // A list of possible IDs to translate.  Work through in reverse order
         // so the last one translated is left in arg_url.
         int extracted_index = -1;  // Which list item is copied to arg_url?
         for (int i = tab_list->GetSize() - 1; i >= 0; --i) {
           if (tab_list->GetInteger(i, &tab_id) &&
               GetUrlForTabId(tab_id, profile, &arg_url, &arg_incognito)) {
             if (!arg_incognito)
-              tab_list->Set(i, new base::Value(arg_url.spec()));
+              tab_list->Set(i, base::MakeUnique<base::Value>(arg_url.spec()));
             extracted_index = i;
           }
         }
         if (extracted_index >= 0) {
-          tab_list->Set(extracted_index, new base::Value(kArgUrlPlaceholder));
+          tab_list->Set(extracted_index,
+                        base::MakeUnique<base::Value>(kArgUrlPlaceholder));
         }
       }
       break;
     }
 
     default:
       NOTREACHED();
   }
 
   if (arg_url.is_valid()) {
@@ skipping 595 matching lines @@
   }
 }
 
 template <>
 void BrowserContextKeyedAPIFactory<ActivityLog>::DeclareFactoryDependencies() {
   DependsOn(ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());
   DependsOn(ExtensionRegistryFactory::GetInstance());
 }
 
 }  // namespace extensions