chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Just rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api.cc ('K') | « chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h

diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h b/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h

index 1d0feab2a2012b2277d7729600d9d5a5b5c00850..8c4ae9aea648d426f6057d6d583f3df0acd45cef 100644

--- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h

+++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h

@@ -5,6 +5,8 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_SYNC_FILE_SYSTEM_SYNC_FILE_SYSTEM_API_HELPERS_H_

#define CHROME_BROWSER_EXTENSIONS_API_SYNC_FILE_SYSTEM_SYNC_FILE_SYSTEM_API_HELPERS_H_

+#include <memory>

#include "chrome/browser/sync_file_system/conflict_resolution_policy.h"

#include "chrome/browser/sync_file_system/sync_action.h"

#include "chrome/browser/sync_file_system/sync_direction.h"

@@ -52,7 +54,7 @@ ExtensionEnumToConflictResolutionPolicy(

// in the renderer's customer binding to create a FileEntry object.

// This returns NULL if the given |url| is not valid or |file_type| is

// SYNC_FILE_TYPE_UNKNOWN.

-base::DictionaryValue* CreateDictionaryValueForFileSystemEntry(

+std::unique_ptr<base::DictionaryValue> CreateDictionaryValueForFileSystemEntry(

const storage::FileSystemURL& url,

sync_file_system::SyncFileType file_type);