Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
index e85a7ef0098e34c80fc6db5349dc9a3fe14fc841..28b5f4fa644d6fd7834fad59a8fa25fb19f96048 100644
--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/extension_gcm_app_handler.h"
#include <memory>
+#include <utility>
#include <vector>
#include "base/bind.h"
@@ -287,9 +288,9 @@ class ExtensionGCMAppHandlerTest : public testing::Test {
base::DictionaryValue manifest;
manifest.SetString(manifest_keys::kVersion, "1.0.0.0");
manifest.SetString(manifest_keys::kName, kTestExtensionName);
- base::ListValue* permission_list = new base::ListValue;
+ auto permission_list = base::MakeUnique<base::ListValue>();
permission_list->AppendString("gcm");
- manifest.Set(manifest_keys::kPermissions, permission_list);
+ manifest.Set(manifest_keys::kPermissions, std::move(permission_list));
std::string error;
scoped_refptr<Extension> extension = Extension::Create(

Powered by Google App Engine
This is Rietveld 408576698