Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4438)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_api.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_api.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc
index cee1a77fd54341bdef6a46ba4e7ba49e0b11f67e..850814c9026c750f01b283b22d5bd2291b6e0259 100644
--- a/chrome/browser/extensions/api/cookies/cookies_api.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_api.cc
@@ -556,12 +556,12 @@ ExtensionFunction::ResponseAction CookiesGetAllCookieStoresFunction::Run() {
std::vector<cookies::CookieStore> cookie_stores;
if (original_tab_ids->GetSize() > 0) {
cookie_stores.push_back(cookies_helpers::CreateCookieStore(
- original_profile, original_tab_ids.release()));
+ original_profile, std::move(original_tab_ids)));
}
if (incognito_tab_ids.get() && incognito_tab_ids->GetSize() > 0 &&
incognito_profile) {
cookie_stores.push_back(cookies_helpers::CreateCookieStore(
- incognito_profile, incognito_tab_ids.release()));
+ incognito_profile, std::move(incognito_tab_ids)));
}
return RespondNow(
ArgumentList(GetAllCookieStores::Results::Create(cookie_stores)));

Powered by Google App Engine
This is Rietveld 408576698