Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
index 18fd5f611b8b91b38130251cf02f22ba87fa4054..32bfabcef70884e60e586d5d71bb3722a123b825 100644
--- a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
@@ -175,12 +175,12 @@ TEST_F(FileSystemProviderOperationsReadFileTest, OnSuccess) {
const int execution_time = 0;
base::ListValue value_as_list;
- value_as_list.Set(0, new base::Value(kFileSystemId));
- value_as_list.Set(1, new base::Value(kRequestId));
+ value_as_list.Set(0, base::MakeUnique<base::Value>(kFileSystemId));
+ value_as_list.Set(1, base::MakeUnique<base::Value>(kRequestId));
value_as_list.Set(
2, base::BinaryValue::CreateWithCopiedBuffer(data.c_str(), data.size()));
- value_as_list.Set(3, new base::Value(has_more));
- value_as_list.Set(4, new base::Value(execution_time));
+ value_as_list.Set(3, base::MakeUnique<base::Value>(has_more));
+ value_as_list.Set(4, base::MakeUnique<base::Value>(execution_time));
std::unique_ptr<Params> params(Params::Create(value_as_list));
ASSERT_TRUE(params.get());

Powered by Google App Engine
This is Rietveld 408576698