Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
diff --git a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc b/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
index 783b0b656b0b7558ede34d1bf66e2455ea50f42a..ebd91a7b10b56cdeb395db284e00c5d9eb4f126d 100644
--- a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
+++ b/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/api/messaging/native_messaging_test_util.h"
#include <memory>
+#include <utility>
#include "base/files/file_path.h"
#include "base/json/json_file_value_serializer.h"
@@ -37,7 +38,7 @@ void WriteTestNativeHostManifest(const base::FilePath& target_dir,
std::unique_ptr<base::ListValue> origins(new base::ListValue());
origins->AppendString(base::StringPrintf(
"chrome-extension://%s/", ScopedTestNativeMessagingHost::kExtensionId));
- manifest->Set("allowed_origins", origins.release());
+ manifest->Set("allowed_origins", std::move(origins));
base::FilePath manifest_path = target_dir.AppendASCII(host_name + ".json");
JSONFileValueSerializer serializer(manifest_path);

Powered by Google App Engine
This is Rietveld 408576698