Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/extension_web_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_web_ui.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"

[jdoerrie, 2017/04/06 14:25:51]

#include "base/values.h"

[vabr (Chromium), 2017/04/07 20:40:41]

Done.

 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/url_constants.h"
 #include "components/favicon/core/favicon_service.h"
 #include "components/favicon_base/favicon_util.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 #include "components/prefs/scoped_user_pref_update.h"
@@ skipping 435 matching lines @@
 // static
 void ExtensionWebUI::RegisterOrActivateChromeURLOverrides(
     Profile* profile,
     const URLOverrides::URLOverrideMap& overrides) {
   if (overrides.empty())
     return;
   PrefService* prefs = profile->GetPrefs();
   DictionaryPrefUpdate update(prefs, kExtensionURLOverrides);
   base::DictionaryValue* all_overrides = update.Get();
   for (const auto& page_override_pair : overrides) {
-    base::ListValue* page_overrides = nullptr;
-    if (!all_overrides->GetList(page_override_pair.first, &page_overrides)) {
-      page_overrides = new base::ListValue();
-      all_overrides->Set(page_override_pair.first, page_overrides);
+    base::ListValue* page_overrides_weak = nullptr;
+    if (!all_overrides->GetList(page_override_pair.first,
+                                &page_overrides_weak)) {
+      auto page_overrides = base::MakeUnique<base::ListValue>();
+      page_overrides_weak = page_overrides.get();
+      all_overrides->Set(page_override_pair.first, std::move(page_overrides));
     }
-    AddOverridesToList(page_overrides, page_override_pair.second.spec());
+    AddOverridesToList(page_overrides_weak, page_override_pair.second.spec());
   }
 }
 
 // static
 void ExtensionWebUI::DeactivateChromeURLOverrides(
     Profile* profile,
     const URLOverrides::URLOverrideMap& overrides) {
   UpdateOverridesLists(profile, overrides, UPDATE_DEACTIVATE);
 }
 
@@ skipping 36 matching lines @@
         extensions::ImageLoader::ImageRepresentation::ALWAYS_RESIZE,
         gfx::Size(pixel_size, pixel_size),
         resource_scale_factor));
   }
 
   // LoadImagesAsync actually can run callback synchronously. We want to force
   // async.
   extensions::ImageLoader::Get(profile)->LoadImagesAsync(
       extension, info_list, base::Bind(&RunFaviconCallbackAsync, callback));
 }