Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: chrome/browser/prefs/session_startup_pref_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Just rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/session_startup_pref_unittest.cc
diff --git a/chrome/browser/prefs/session_startup_pref_unittest.cc b/chrome/browser/prefs/session_startup_pref_unittest.cc
index b025f0ef5cc2c9da7248375f897a8cbcc2ed7f9a..d0746b8a875976fec30540d0a1ae3c9604a43c0a 100644
--- a/chrome/browser/prefs/session_startup_pref_unittest.cc
+++ b/chrome/browser/prefs/session_startup_pref_unittest.cc
@@ -28,8 +28,8 @@ class SessionStartupPrefTest : public testing::Test {
TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
auto url_pref_list = base::MakeUnique<base::ListValue>();
- url_pref_list->Set(0, new base::Value("google.com"));
- url_pref_list->Set(1, new base::Value("chromium.org"));
+ url_pref_list->Set(0, base::MakeUnique<base::Value>("google.com"));
+ url_pref_list->Set(1, base::MakeUnique<base::Value>("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup,
std::move(url_pref_list));
@@ -42,14 +42,14 @@ TEST_F(SessionStartupPrefTest, URLListIsFixedUp) {
TEST_F(SessionStartupPrefTest, URLListManagedOverridesUser) {
auto url_pref_list1 = base::MakeUnique<base::ListValue>();
- url_pref_list1->Set(0, new base::Value("chromium.org"));
+ url_pref_list1->Set(0, base::MakeUnique<base::Value>("chromium.org"));
pref_service_->SetUserPref(prefs::kURLsToRestoreOnStartup,
std::move(url_pref_list1));
auto url_pref_list2 = base::MakeUnique<base::ListValue>();
- url_pref_list2->Set(0, new base::Value("chromium.org"));
- url_pref_list2->Set(1, new base::Value("chromium.org"));
- url_pref_list2->Set(2, new base::Value("chromium.org"));
+ url_pref_list2->Set(0, base::MakeUnique<base::Value>("chromium.org"));
+ url_pref_list2->Set(1, base::MakeUnique<base::Value>("chromium.org"));
+ url_pref_list2->Set(2, base::MakeUnique<base::Value>("chromium.org"));
pref_service_->SetManagedPref(prefs::kURLsToRestoreOnStartup,
std::move(url_pref_list2));

Powered by Google App Engine
This is Rietveld 408576698