[Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

[Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

BUG=

Committed: https://crrev.com/671946a042b48dc7f38809c3df970300ee54d845
Cr-Commit-Position: refs/heads/master@{#422454}

[skym, 2016-09-28 00:02:19]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 00:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 00:14:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 00:14:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2016-09-29 19:39:52]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 19:40:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:03:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2016-09-29 20:06:09]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:06:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-09-29 20:15:36]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2016-09-29 20:15:45]

Description was changed from

==========
[Sync] Refactoring of sync integration test checkers to remove boilerplate await
methods.

BUG=
==========

to

==========
[Sync] Refactoring of sync integration test checkers to remove boilerplate await
methods.

BUG=
==========

[skym, 2016-09-29 20:15:45]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:15:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-09-29 20:16:17]

PTAL, hopefully PS#4 fixes the ChromeOS builds.

[commit-bot: I haz the power, 2016-09-29 22:33:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 22:33:33]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-09-30 16:27:56]

lgtm w/ minor comments

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/autofill_helper.cc (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/autofill_helper.cc:422: // TODO(skym): If
Wait() isn't immediately called, it's possible this might be
You could always make Wait() virtual and override it here.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/autofill_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/autofill_helper.h:117: class
AutofillKeysChecker : public MultiClientStatusChangeChecker {
I still think it's weird that these are outside the namespace but I guess it
makes sense. The namespace is just to contain the myriad of static functions.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/bookmarks_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/bookmarks_helper.h:232: class
BookmarksTitleChecker : public SingleClientStatusChangeChecker {
Give this guy a real class comment in addition to the TODO?

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/preferences_helper.cc (left):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/preferences_helper.cc:363: bool
AwaitListPrefMatches(const char* pref_name) {
I'm not even halfway through this CL and I can't believe how many methods
exactly like this got made without someone considering changing things.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/preferences_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/preferences_helper.h:107: class
PrefMatchChecker : public StatusChangeChecker {
class comment

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sessions_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sessions_helper.h:117: class
CheckForeignSessionsChecker : public MultiClientStatusChangeChecker {
Shouldn't this be ForeignSessionsMatchChecker to follow the same pattern as all
the others?

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/status_change_checker.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/status_change_checker.h:31: // Returns a
bool representing if the state the checker is currently in its
"Returns whether the state the checker is currently in is its desired
configuration."

Also it's such a descriptive function name you barely need a comment :o

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/status_change_checker.h:35: // Block if
IsExitConditionSatisfied() is currently false until TimeOut()
"TimedOut()"

Also this makes it sound like you check IsExitConditionSatisfied once and then
wait for TimedOut after that. Maybe clarify that CheckExitCondition can cause
this to exit before TimedOut?

[skym, 2016-09-30 17:43:22]

Updates for Max.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/autofill_helper.cc (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/autofill_helper.cc:422: // TODO(skym): If
Wait() isn't immediately called, it's possible this might be
On 2016/09/30 16:27:55, maxbogue wrote:
> You could always make Wait() virtual and override it here.

True. I kinda of wanted to understand better what was going on here and see if
we needed to do this, but that might never happen.

Done.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/autofill_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/autofill_helper.h:117: class
AutofillKeysChecker : public MultiClientStatusChangeChecker {
On 2016/09/30 16:27:55, maxbogue wrote:
> I still think it's weird that these are outside the namespace but I guess it
> makes sense. The namespace is just to contain the myriad of static functions.

Acknowledged.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/bookmarks_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/bookmarks_helper.h:232: class
BookmarksTitleChecker : public SingleClientStatusChangeChecker {
On 2016/09/30 16:27:55, maxbogue wrote:
> Give this guy a real class comment in addition to the TODO?

Done.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/preferences_helper.cc (left):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/preferences_helper.cc:363: bool
AwaitListPrefMatches(const char* pref_name) {
On 2016/09/30 16:27:55, maxbogue wrote:
> I'm not even halfway through this CL and I can't believe how many methods
> exactly like this got made without someone considering changing things.

Right!?

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/preferences_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/preferences_helper.h:107: class
PrefMatchChecker : public StatusChangeChecker {
On 2016/09/30 16:27:55, maxbogue wrote:
> class comment

Done.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/sessions_helper.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/sessions_helper.h:117: class
CheckForeignSessionsChecker : public MultiClientStatusChangeChecker {
On 2016/09/30 16:27:55, maxbogue wrote:
> Shouldn't this be ForeignSessionsMatchChecker to follow the same pattern as
all
> the others?

Done.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/status_change_checker.h (right):

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/status_change_checker.h:31: // Returns a
bool representing if the state the checker is currently in its
On 2016/09/30 16:27:56, maxbogue wrote:
> "Returns whether the state the checker is currently in is its desired
> configuration."
> 
> Also it's such a descriptive function name you barely need a comment :o

Right? I was trying really hard to not just repeat the words the method name was
made of!

Also, Done.

https://codereview.chromium.org/2379433002/diff/60001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/status_change_checker.h:35: // Block if
IsExitConditionSatisfied() is currently false until TimeOut()
On 2016/09/30 16:27:56, maxbogue wrote:
> "TimedOut()"
> 
> Also this makes it sound like you check IsExitConditionSatisfied once and then
> wait for TimedOut after that. Maybe clarify that CheckExitCondition can cause
> this to exit before TimedOut?

Done.

[skym, 2016-09-30 17:43:28]

The CQ bit was checked by skym@chromium.org

[skym, 2016-09-30 17:43:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2379433002/#ps80001
(title: "Updates for Max.")

[commit-bot: I haz the power, 2016-09-30 17:43:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-09-30 19:02:11]

The CQ bit was unchecked by maxbogue@chromium.org

[maxbogue, 2016-09-30 19:03:53]

Sorry, noticed something so I unchecked the cq :S

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/preferences_helper.h (right):

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/preferences_helper.h:107: // Abstract
checker that takes care of registering to preference changes.
s/to/for

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/status_change_checker.h (right):

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/status_change_checker.h:38: // and continue
to block if not. Returns true if and only if timeout occurs.
This is wrong now: "Returns true if and only if timeout occurs." should be
inverted.

[skym, 2016-09-30 19:06:52]

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/preferences_helper.h (right):

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/preferences_helper.h:107: // Abstract
checker that takes care of registering to preference changes.
On 2016/09/30 19:03:52, maxbogue wrote:
> s/to/for

Done.

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
File chrome/browser/sync/test/integration/status_change_checker.h (right):

https://codereview.chromium.org/2379433002/diff/80001/chrome/browser/sync/tes...
chrome/browser/sync/test/integration/status_change_checker.h:38: // and continue
to block if not. Returns true if and only if timeout occurs.
On 2016/09/30 19:03:53, maxbogue wrote:
> This is wrong now: "Returns true if and only if timeout occurs." should be
> inverted.

Done.

[skym, 2016-09-30 19:06:59]

The CQ bit was checked by skym@chromium.org

[skym, 2016-09-30 19:07:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2379433002/#ps100001
(title: "Fixing comment mistakes.")

[commit-bot: I haz the power, 2016-09-30 19:07:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:03:11]

Failed to apply patch for
chrome/browser/sync/test/integration/autofill_helper.cc:
While running git apply --index -3 -p1;
  error: patch failed: chrome/browser/sync/test/integration/autofill_helper.cc:6
  Falling back to three-way merge...
  Applied patch to 'chrome/browser/sync/test/integration/autofill_helper.cc'
with conflicts.
  U chrome/browser/sync/test/integration/autofill_helper.cc

Patch:       chrome/browser/sync/test/integration/autofill_helper.cc
Index: chrome/browser/sync/test/integration/autofill_helper.cc
diff --git a/chrome/browser/sync/test/integration/autofill_helper.cc
b/chrome/browser/sync/test/integration/autofill_helper.cc
index
f88a9e7d5604f7c5c0cc2f6b509ad3162406ef2e..9e885e412a41734144c29c4a54add24a16d9b5ac
100644
--- a/chrome/browser/sync/test/integration/autofill_helper.cc
+++ b/chrome/browser/sync/test/integration/autofill_helper.cc
@@ -6,13 +6,14 @@
 
 #include <stddef.h>
 
+#include <map>
+
 #include "base/guid.h"
 #include "base/run_loop.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_test_util.h"
-#include
"chrome/browser/sync/test/integration/multi_client_status_change_checker.h"
 #include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "chrome/browser/web_data_service_factory.h"
@@ -20,7 +21,6 @@
 #include "components/autofill/core/browser/autofill_test_utils.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
-#include "components/autofill/core/browser/personal_data_manager_observer.h"
 #include "components/autofill/core/browser/webdata/autofill_entry.h"
 #include "components/autofill/core/browser/webdata/autofill_table.h"
 #include "components/autofill/core/browser/webdata/autofill_webdata_service.h"
@@ -255,47 +255,6 @@ bool KeysMatch(int profile_a, int profile_b) {
   return GetAllKeys(profile_a) == GetAllKeys(profile_b);
 }
 
-namespace {
-
-class KeysMatchStatusChecker : public MultiClientStatusChangeChecker {
- public:
-  KeysMatchStatusChecker(int profile_a, int profile_b);
-  ~KeysMatchStatusChecker() override;
-
-  bool IsExitConditionSatisfied() override;
-  std::string GetDebugMessage() const override;
-
- private:
-  const int profile_a_;
-  const int profile_b_;
-};
-
-KeysMatchStatusChecker::KeysMatchStatusChecker(int profile_a, int profile_b)
-    : MultiClientStatusChangeChecker(
-          sync_datatype_helper::test()->GetSyncServices()),
-      profile_a_(profile_a),
-      profile_b_(profile_b) {
-}
-
-KeysMatchStatusChecker::~KeysMatchStatusChecker() {
-}
-
-bool KeysMatchStatusChecker::IsExitConditionSatisfied() {
-  return KeysMatch(profile_a_, profile_b_);
-}
-
-std::string KeysMatchStatusChecker::GetDebugMessage() const {
-  return "Waiting for matching autofill keys";
-}
-
-}  // namespace
-
-bool AwaitKeysMatch(int a, int b) {
-  KeysMatchStatusChecker checker(a, b);
-  checker.Wait();
-  return !checker.TimedOut();
-}
-
 void SetProfiles(int profile, std::vector<AutofillProfile>* autofill_profiles)
{
   MockPersonalDataManagerObserver observer;
   EXPECT_CALL(observer, OnPersonalDataChanged()).
@@ -434,86 +393,52 @@ bool AllProfilesMatch() {
   return true;
 }
 
-namespace {
-
-class ProfilesMatchStatusChecker : public StatusChangeChecker,
-                                   public PersonalDataManagerObserver {
- public:
-  ProfilesMatchStatusChecker(int profile_a, int profile_b);
-  ~ProfilesMatchStatusChecker() override;
-
-  // StatusChangeChecker implementation.
-  bool IsExitConditionSatisfied() override;
-  std::string GetDebugMessage() const override;
+}  // namespace autofill_helper
 
-  // PersonalDataManager implementation.
-  void OnPersonalDataChanged() override;
+AutofillKeysChecker::AutofillKeysChecker(int profile_a, int profile_b)
+    : MultiClientStatusChangeChecker(
+          sync_datatype_helper::test()->GetSyncServices()),
+      profile_a_(profile_a),
+      profile_b_(profile_b) {}
 
-  // Wait for conidtion to beome true.
-  void Wait();
+bool AutofillKeysChecker::IsExitConditionSatisfied() {
+  return autofill_helper::KeysMatch(profile_a_, profile_b_);
+}
 
- private:
-  const int profile_a_;
-  const int profile_b_;
-  bool registered_;
-};
+std::string AutofillKeysChecker::GetDebugMessage() const {
+  return "Waiting for matching autofill keys";
+}
 
-ProfilesMatchStatusChecker::ProfilesMatchStatusChecker(int profile_a,
-                                                       int profile_b)
-    : profile_a_(profile_a), profile_b_(profile_b), registered_(false) {
+AutofillProfileChecker::AutofillProfileChecker(int profile_a, int profile_b)
+    : profile_a_(profile_a), profile_b_(profile_b) {
+  autofill_helper::GetPersonalDataManager(profile_a_)->AddObserver(this);
+  autofill_helper::GetPersonalDataManager(profile_b_)->AddObserver(this);
 }
 
-ProfilesMatchStatusChecker::~ProfilesMatchStatusChecker() {
-  PersonalDataManager* pdm_a = GetPersonalDataManager(profile_a_);
-  PersonalDataManager* pdm_b = GetPersonalDataManager(profile_b_);
-  if (registered_) {
-    pdm_a->RemoveObserver(this);
-    pdm_b->RemoveObserver(this);
-  }
+AutofillProfileChecker::~AutofillProfileChecker() {
+  autofill_helper::GetPersonalDataManager(profile_a_)->RemoveObserver(this);
+  autofill_helper::GetPersonalDataManager(profile_b_)->RemoveObserver(this);
 }
 
-bool ProfilesMatchStatusChecker::IsExitConditionSatisfied() {
-  PersonalDataManager* pdm_a = GetPersonalDataManager(profile_a_);
-  PersonalDataManager* pdm_b = GetPersonalDataManager(profile_b_);
+bool AutofillProfileChecker::Wait() {
+  autofill_helper::GetPersonalDataManager(profile_a_)->Refresh();
+  autofill_helper::GetPersonalDataManager(profile_b_)->Refresh();
+  return StatusChangeChecker::Wait();
+}
 
+bool AutofillProfileChecker::IsExitConditionSatisfied() {
   const std::vector<AutofillProfile*>& autofill_profiles_a =
-      pdm_a->web_profiles();
+      autofill_helper::GetPersonalDataManager(profile_a_)->web_profiles();
   const std::vector<AutofillProfile*>& autofill_profiles_b =
-      pdm_b->web_profiles();
-
-  return ProfilesMatchImpl(
-      profile_a_, autofill_profiles_a, profile_b_, autofill_profiles_b);
-}
-
-void ProfilesMatchStatusChecker::Wait() {
-  PersonalDataManager* pdm_a = GetPersonalDataManager(profile_a_);
-  PersonalDataManager* pdm_b = GetPersonalDataManager(profile_b_);
-
-  pdm_a->AddObserver(this);
-  pdm_b->AddObserver(this);
-
-  pdm_a->Refresh();
-  pdm_b->Refresh();
-
-  registered_ = true;
-
-  StartBlockingWait();
+      autofill_helper::GetPersonalDataManager(profile_b_)->web_profiles();
+  return autofill_helper::ProfilesMatchImpl(profile_a_, autofill_profiles_a,
+                                            profile_b_, autofill_profiles_b);
 }
 
-std::string ProfilesMatchStatusChecker::GetDebugMessage() const {
+std::string AutofillProfileChecker::GetDebugMessage() const {
   return "Waiting for matching autofill profiles";
 }
 
-void ProfilesMatchStatusChecker::OnPersonalDataChanged() {
+void AutofillProfileChecker::OnPersonalDataChanged() {
   CheckExitCondition();
 }
-
-}  // namespace
-
-bool AwaitProfilesMatch(int a, int b) {
-  ProfilesMatchStatusChecker checker(a, b);
-  checker.Wait();
-  return !checker.TimedOut();
-}
-
-}  // namespace autofill_helper

[skym, 2016-10-03 16:54:28]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 16:54:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 17:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 17:43:47]

Dry run: This issue passed the CQ dry run.

[skym, 2016-10-03 17:44:20]

The CQ bit was checked by skym@chromium.org

[skym, 2016-10-03 17:44:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2379433002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-03 17:44:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 17:52:45]

Description was changed from

==========
[Sync] Refactoring of sync integration test checkers to remove boilerplate await
methods.

BUG=
==========

to

==========
[Sync] Refactoring of sync integration test checkers to remove boilerplate await
methods.

BUG=
==========

[commit-bot: I haz the power, 2016-10-03 17:52:47]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-03 17:55:12]

Description was changed from

==========
[Sync] Refactoring of sync integration test checkers to remove boilerplate await
methods.

BUG=
==========

to

==========
[Sync] Refactoring of sync integration test checkers to remove boilerplate await
methods.

BUG=

Committed: https://crrev.com/671946a042b48dc7f38809c3df970300ee54d845
Cr-Commit-Position: refs/heads/master@{#422454}
==========

[commit-bot: I haz the power, 2016-10-03 17:55:14]

Patchset 7 (id:??) landed as
https://crrev.com/671946a042b48dc7f38809c3df970300ee54d845
Cr-Commit-Position: refs/heads/master@{#422454}