[Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

chrome/browser/sync/test/integration/preferences_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_PREFERENCES_HELPER_H_
 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_PREFERENCES_HELPER_H_
 
+#include <stdint.h>
+
+#include <memory>
+#include <string>
+#include <vector>
+
 #include "base/files/file_path.h"
 #include "base/values.h"
+#include "chrome/browser/sync/test/integration/multi_client_status_change_checker.h"
 
-#include <stdint.h>
-
-#include <string>
-
+class PrefChangeRegistrar;
 class PrefService;
 
 namespace preferences_helper {
 
 // Used to access the preferences within a particular sync profile.
 PrefService* GetPrefs(int index);
 
 // Used to access the preferences within the verifier sync profile.
 PrefService* GetVerifierPrefs();
 
@@ skipping 66 matching lines @@
 // Used to verify that the file path preference with name |pref_name| has the
 // same value across all profiles. Also checks |verifier| if DisableVerifier()
 // hasn't been called.
 bool FilePathPrefMatches(const char* pref_name) WARN_UNUSED_RESULT;
 
 // Used to verify that the list preference with name |pref_name| has the
 // same value across all profiles. Also checks |verifier| if DisableVerifier()
 // hasn't been called.
 bool ListPrefMatches(const char* pref_name) WARN_UNUSED_RESULT;
 
-// This is the version of ListPrefMatches that waits for the preference list
-// to match in all profiles. Returns false if this operation times out.
-bool AwaitListPrefMatches(const char* pref_name) WARN_UNUSED_RESULT;
-
-// Blocks the test until the specified pref matches on all relevant clients or
-// a timeout occurs.  Returns false if it returns because of a timeout.
-bool AwaitBooleanPrefMatches(const char* pref_name) WARN_UNUSED_RESULT;
-
-// Blocks the test until the specified pref matches on all relevant clients or
-// a timeout occurs.  Returns false if it returns because of a timeout.
-bool AwaitIntegerPrefMatches(const char* pref_name) WARN_UNUSED_RESULT;
-
-// Blocks the test until the specified pref matches on all relevant clients or
-// a timeout occurs.  Returns false if it returns because of a timeout.
-bool AwaitStringPrefMatches(const char* pref_name) WARN_UNUSED_RESULT;
-
 }  // namespace preferences_helper
 
+// Abstract checker that takes care of registering to preference changes.

[maxbogue, 2016/09/30 19:03:52]

s/to/for

[skym, 2016/09/30 19:06:52]

Done.

+class PrefMatchChecker : public StatusChangeChecker {
+ public:
+  explicit PrefMatchChecker(const char* path);
+  ~PrefMatchChecker() override;
+
+  // StatusChangeChecker implementation.
+  bool IsExitConditionSatisfied() override = 0;
+  std::string GetDebugMessage() const override;
+
+ protected:
+  const char* GetPath() const;
+
+ private:
+  void RegisterPrefListener(PrefService* pref_service);
+
+  std::vector<std::unique_ptr<PrefChangeRegistrar>> pref_change_registrars_;
+  const char* path_;
+};
+
+// Matcher that blocks until the specified list pref matches on all clients.
+class ListPrefMatchChecker : public PrefMatchChecker {
+ public:
+  explicit ListPrefMatchChecker(const char* path);
+
+  // PrefMatchChecker implementation.
+  bool IsExitConditionSatisfied() override;
+};
+
+// Matcher that blocks until the specified boolean pref matches on all clients.
+class BooleanPrefMatchChecker : public PrefMatchChecker {
+ public:
+  explicit BooleanPrefMatchChecker(const char* path);
+
+  // PrefMatchChecker implementation.
+  bool IsExitConditionSatisfied() override;
+};
+
+// Matcher that blocks until the specified integer pref matches on all clients.
+class IntegerPrefMatchChecker : public PrefMatchChecker {
+ public:
+  explicit IntegerPrefMatchChecker(const char* path);
+
+  // PrefMatchChecker implementation.
+  bool IsExitConditionSatisfied() override;
+};
+
+// Matcher that blocks until the specified string pref matches on all clients.
+class StringPrefMatchChecker : public PrefMatchChecker {
+ public:
+  explicit StringPrefMatchChecker(const char* path);
+
+  // PrefMatchChecker implementation.
+  bool IsExitConditionSatisfied() override;
+};
+
 #endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_PREFERENCES_HELPER_H_