[Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

chrome/browser/sync/test/integration/bookmarks_helper.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
+#include "chrome/browser/sync/test/integration/await_match_status_change_checker.h"
+#include "chrome/browser/sync/test/integration/multi_client_status_change_checker.h"
+#include "chrome/browser/sync/test/integration/single_client_status_change_checker.h"
 #include "third_party/skia/include/core/SkColor.h"
 
 class GURL;
 
 namespace bookmarks {
 class BookmarkModel;
 class BookmarkNode;
 }
 
 namespace gfx {
@@ skipping 129 matching lines @@
 
 // Checks if the bookmark models of |profile_a| and |profile_b| match each
 // other. Returns true if they match.
 bool ModelsMatch(int profile_a, int profile_b) WARN_UNUSED_RESULT;
 
 // Checks if the bookmark models of all sync profiles match each other. Does
 // not compare them with the verifier bookmark model. Returns true if they
 // match.
 bool AllModelsMatch() WARN_UNUSED_RESULT;
 
-// Check if the bookmarks models of all sync profiles match each other, using
-// AllModelsMatch. Returns true if bookmark models match and don't timeout
-// while checking.
-bool AwaitAllModelsMatch() WARN_UNUSED_RESULT;
-
-// Blocks the caller until the given |profile| contains |expected_count|
-// bookmarks with |title| or until waiting times out.
-bool AwaitCountBookmarksWithTitlesMatching(int profile,
-                                           const std::string& title,
-                                           int expected_count)
-    WARN_UNUSED_RESULT;
-
-// Blocks the caller until the given |profile| contains |expected_count|
-// bookmarks with |url| or until waiting times out.
-bool AwaitCountBookmarksWithUrlsMatching(int profile,
-                                         const GURL& url,
-                                         int expected_count) WARN_UNUSED_RESULT;
-
 // Checks if the bookmark model of profile |profile| contains any instances of
 // two bookmarks with the same URL under the same parent folder. Returns true
 // if even one instance is found.
 bool ContainsDuplicateBookmarks(int profile);
 
 // Returns whether a node exists with the specified url.
 bool HasNodeWithURL(int profile, const GURL& url);
 
 // Gets the node in the bookmark model of profile |profile| that has the url
 // |url|. Note: Only one instance of |url| is assumed to be present.
@@ skipping 37 matching lines @@
 std::string IndexedFolderName(int i);
 
 // Returns a subfolder name identifiable by |i|.
 std::string IndexedSubfolderName(int i);
 
 // Returns a subsubfolder name identifiable by |i|.
 std::string IndexedSubsubfolderName(int i);
 
 }  // namespace bookmarks_helper
 
+// Checker used to block until bookmarks match on all clients.
+class BookmarksMatchChecker : public MultiClientStatusChangeChecker {
+ public:
+  BookmarksMatchChecker();
+
+  // StatusChangeChecker implementation.
+  bool IsExitConditionSatisfied() override;
+  std::string GetDebugMessage() const override;
+};
+
+// TODO(pvalenzuela): Remove this class and instead use
+// AwaitMatchStatusChangeChecker.
+class BookmarksTitleChecker : public SingleClientStatusChangeChecker {

[maxbogue, 2016/09/30 16:27:55]

Give this guy a real class comment in addition to the TODO?

[skym, 2016/09/30 17:43:21]

Done.

+ public:
+  BookmarksTitleChecker(int profile_index,
+                        const std::string& title,
+                        int expected_count);
+
+  // StatusChangeChecker implementation.
+  bool IsExitConditionSatisfied() override;
+  std::string GetDebugMessage() const override;
+
+ private:
+  const int profile_index_;
+  const std::string title_;
+  const int expected_count_;
+};
+
+// Checker used to block until the actual number of bookmarks with the given url
+// match the expected count.
+class BookmarksUrlChecker : public AwaitMatchStatusChangeChecker {
+ public:
+  BookmarksUrlChecker(int profile, const GURL& url, int expected_count);
+};
+
 #endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_