Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3131)

Unified Diff: chrome/browser/sync/test/integration/multi_client_status_change_checker.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/multi_client_status_change_checker.cc
diff --git a/chrome/browser/sync/test/integration/multi_client_status_change_checker.cc b/chrome/browser/sync/test/integration/multi_client_status_change_checker.cc
index ac75172f1e226d2e02d3dd5333b94600dc83e21f..1b8868a53264a1592b431675f04d4667063ccb04 100644
--- a/chrome/browser/sync/test/integration/multi_client_status_change_checker.cc
+++ b/chrome/browser/sync/test/integration/multi_client_status_change_checker.cc
@@ -10,30 +10,14 @@
MultiClientStatusChangeChecker::MultiClientStatusChangeChecker(
std::vector<browser_sync::ProfileSyncService*> services)
- : services_(services) {}
-
-MultiClientStatusChangeChecker::~MultiClientStatusChangeChecker() {}
-
-void MultiClientStatusChangeChecker::Wait() {
- DVLOG(1) << "Await: " << GetDebugMessage();
-
- if (IsExitConditionSatisfied()) {
- DVLOG(1) << "Await -> Exit before waiting: " << GetDebugMessage();
- return;
+ : services_(services), scoped_observer_(this) {
+ for (browser_sync::ProfileSyncService* service : services) {
+ scoped_observer_.Add(service);
}
-
- ScopedObserver<browser_sync::ProfileSyncService,
- MultiClientStatusChangeChecker>
- obs(this);
- for (std::vector<browser_sync::ProfileSyncService*>::iterator it =
- services_.begin();
- it != services_.end(); ++it) {
- obs.Add(*it);
- }
-
- StartBlockingWait();
}
+MultiClientStatusChangeChecker::~MultiClientStatusChangeChecker() {}
+
void MultiClientStatusChangeChecker::OnStateChanged() {
CheckExitCondition();
}

Powered by Google App Engine
This is Rietveld 408576698