Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/sync/test/integration/multi_client_status_change_checker.h

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/multi_client_status_change_checker.h
diff --git a/chrome/browser/sync/test/integration/multi_client_status_change_checker.h b/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
index 49c7a2657adb19963b2da08b4f617c83e5b28b47..a09bd53d48af1a0b456001f6375316f36380ad01 100644
--- a/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
+++ b/chrome/browser/sync/test/integration/multi_client_status_change_checker.h
@@ -5,9 +5,11 @@
#ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_H_
#define CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_H_
+#include <string>
#include <vector>
#include "base/compiler_specific.h"
+#include "base/scoped_observer.h"
#include "base/time/time.h"
#include "chrome/browser/sync/test/integration/status_change_checker.h"
#include "components/sync/driver/sync_service_observer.h"
@@ -29,9 +31,6 @@ class MultiClientStatusChangeChecker : public StatusChangeChecker,
// Called when waiting times out.
void OnTimeout();
- // Blocks until the exit condition is satisfied or a timeout occurs.
- void Wait();
-
// sync_driver::SyncServiceObserver implementation.
void OnStateChanged() override;
@@ -46,6 +45,9 @@ class MultiClientStatusChangeChecker : public StatusChangeChecker,
private:
std::vector<browser_sync::ProfileSyncService*> services_;
+ ScopedObserver<browser_sync::ProfileSyncService,
+ MultiClientStatusChangeChecker>
+ scoped_observer_;
};
#endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_H_

Powered by Google App Engine
This is Rietveld 408576698