chrome/browser/sync/test/integration/quiesce_status_change_checker.h - Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/quiesce_status_change_checker.h

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/profile_sync_service_harness.cc ('k') | chrome/browser/sync/test/integration/quiesce_status_change_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/quiesce_status_change_checker.h

diff --git a/chrome/browser/sync/test/integration/quiesce_status_change_checker.h b/chrome/browser/sync/test/integration/quiesce_status_change_checker.h

index 59f65e633fdb95bfe52e65b8ed805e256c3b1be4..2effdae1fadf51dd7350708ee7c77abca745338c 100644

--- a/chrome/browser/sync/test/integration/quiesce_status_change_checker.h

+++ b/chrome/browser/sync/test/integration/quiesce_status_change_checker.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_

#define CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_

+#include <string>

#include <vector>

#include "base/compiler_specific.h"

@@ -37,9 +38,6 @@ class QuiesceStatusChangeChecker : public StatusChangeChecker {

std::vector<browser_sync::ProfileSyncService*> services);

~QuiesceStatusChangeChecker() override;

- // Blocks until all clients have quiesced or we time out.

- void Wait();

// A callback function for some helper objects.

void OnServiceStateChanged(browser_sync::ProfileSyncService* service);