chrome/browser/sync/test/integration/quiesce_status_change_checker.cc - Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/quiesce_status_change_checker.h ('k') | chrome/browser/sync/test/integration/search_engines_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

diff --git a/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc b/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

index 38476a97e3a3a6273f716c3d2897e4138653103b..6206314be0d1b651920b4bd7c66a9cefa36dbf84 100644

--- a/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

+++ b/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

@@ -153,17 +153,6 @@ QuiesceStatusChangeChecker::QuiesceStatusChangeChecker(

QuiesceStatusChangeChecker::~QuiesceStatusChangeChecker() {}

-void QuiesceStatusChangeChecker::Wait() {

- DVLOG(1) << "Await: " << GetDebugMessage();

- if (IsExitConditionSatisfied()) {

- DVLOG(1) << "Await -> Exit before waiting: " << GetDebugMessage();

- return;

- }

- StartBlockingWait();

bool QuiesceStatusChangeChecker::IsExitConditionSatisfied() {

// Check that all progress markers are up to date.

for (ScopedVector<ProgressMarkerWatcher>::const_iterator it =