Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6199)

Unified Diff: chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc b/chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc
index 2c69e7f7f3fbe1ab23a992a073de688643020367..bcbca560a4dfcec7538c04dc81a741d61281a99e 100644
--- a/chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc
+++ b/chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc
@@ -4,13 +4,12 @@
#include "base/macros.h"
#include "chrome/browser/sessions/session_service.h"
-#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "chrome/browser/sync/test/integration/typed_urls_helper.h"
+#include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h"
#include "components/browser_sync/profile_sync_service.h"
#include "components/history/core/browser/history_types.h"
-using sync_integration_test_util::AwaitCommitActivityCompletion;
using typed_urls_helper::AddUrlToHistory;
using typed_urls_helper::AddUrlToHistoryWithTransition;
using typed_urls_helper::CheckAllProfilesHaveSameURLs;
@@ -42,7 +41,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, Sanity) {
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
// Wait for sync and verify client did not change.
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));
+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
}
@@ -62,7 +61,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, TwoVisits) {
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
// Wait for sync and verify client did not change.
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));
+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
}
@@ -82,12 +81,12 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, DeleteTyped) {
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
// Wait for sync and verify client did not change.
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));
+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
// Now delete the URL we just added, wait for sync, and verify the deletion.
DeleteUrlFromHistory(0, new_url);
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));
+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
urls = GetTypedUrlsFromClient(0);
ASSERT_EQ(0U, urls.size());
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
@@ -108,12 +107,12 @@ IN_PROC_BROWSER_TEST_F(SingleClientTypedUrlsSyncTest, DeleteNonTyped) {
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
// Wait for sync and verify client did not change.
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));
+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());
// Now delete the URL we just added, wait for sync and verify the deletion.
DeleteUrlFromHistory(0, new_url);
- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));
+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
urls = GetTypedUrlsFromClient(0);
ASSERT_EQ(0U, urls.size());
ASSERT_TRUE(CheckAllProfilesHaveSameURLs());

Powered by Google App Engine
This is Rietveld 408576698