chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc - Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/performance/extensions_sync_perf_test.cc ('k') | chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

diff --git a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

index 204cb50d45b7b7ff26aa01ad42b63a2cf1c37c68..c6104b1109e02ac851eab8ba6716a5b684f7e637 100644

--- a/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

+++ b/chrome/browser/sync/test/integration/performance/passwords_sync_perf_test.cc

@@ -17,6 +17,8 @@ using passwords_helper::CreateTestPasswordForm;

using passwords_helper::GetPasswordCount;

using passwords_helper::GetPasswordStore;

using passwords_helper::UpdateLogin;

+using sync_timing_helper::PrintResult;

+using sync_timing_helper::TimeUntilQuiescence;

static const int kNumPasswords = 150;

@@ -83,19 +85,19 @@ IN_PROC_BROWSER_TEST_F(PasswordsSyncPerfTest, MAYBE_P0) {

// TCM ID - 7367749.

AddLogins(0, kNumPasswords);

- base::TimeDelta dt = SyncTimingHelper::TimeUntilQuiescence(clients());

+ base::TimeDelta dt = TimeUntilQuiescence(clients());

ASSERT_EQ(kNumPasswords, GetPasswordCount(1));

- SyncTimingHelper::PrintResult("passwords", "add_passwords", dt);

+ PrintResult("passwords", "add_passwords", dt);

// TCM ID - 7365093.

UpdateLogins(0);

- dt = SyncTimingHelper::TimeUntilQuiescence(clients());

+ dt = TimeUntilQuiescence(clients());

ASSERT_EQ(kNumPasswords, GetPasswordCount(1));

- SyncTimingHelper::PrintResult("passwords", "update_passwords", dt);

+ PrintResult("passwords", "update_passwords", dt);

// TCM ID - 7557852

RemoveLogins(0);

- dt = SyncTimingHelper::TimeUntilQuiescence(clients());

+ dt = TimeUntilQuiescence(clients());

ASSERT_EQ(0, GetPasswordCount(1));

- SyncTimingHelper::PrintResult("passwords", "delete_passwords", dt);

+ PrintResult("passwords", "delete_passwords", dt);

}