Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Side by Side Diff: chrome/browser/sync/test/integration/multi_client_status_change_checker.h

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_ H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_ H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_ H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECKER_ H_
7 7
8 #include <string>
8 #include <vector> 9 #include <vector>
9 10
10 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/scoped_observer.h"
11 #include "base/time/time.h" 13 #include "base/time/time.h"
12 #include "chrome/browser/sync/test/integration/status_change_checker.h" 14 #include "chrome/browser/sync/test/integration/status_change_checker.h"
13 #include "components/sync/driver/sync_service_observer.h" 15 #include "components/sync/driver/sync_service_observer.h"
14 16
15 namespace browser_sync { 17 namespace browser_sync {
16 class ProfileSyncService; 18 class ProfileSyncService;
17 } // namespace browser_sync 19 } // namespace browser_sync
18 20
19 // This class provides some common functionality for StatusChangeCheckers that 21 // This class provides some common functionality for StatusChangeCheckers that
20 // observe many ProfileSyncServices. This class is abstract. Its descendants 22 // observe many ProfileSyncServices. This class is abstract. Its descendants
21 // are expected to provide additional functionality. 23 // are expected to provide additional functionality.
22 class MultiClientStatusChangeChecker : public StatusChangeChecker, 24 class MultiClientStatusChangeChecker : public StatusChangeChecker,
23 public sync_driver::SyncServiceObserver { 25 public sync_driver::SyncServiceObserver {
24 public: 26 public:
25 explicit MultiClientStatusChangeChecker( 27 explicit MultiClientStatusChangeChecker(
26 std::vector<browser_sync::ProfileSyncService*> services); 28 std::vector<browser_sync::ProfileSyncService*> services);
27 ~MultiClientStatusChangeChecker() override; 29 ~MultiClientStatusChangeChecker() override;
28 30
29 // Called when waiting times out. 31 // Called when waiting times out.
30 void OnTimeout(); 32 void OnTimeout();
31 33
32 // Blocks until the exit condition is satisfied or a timeout occurs.
33 void Wait();
34
35 // sync_driver::SyncServiceObserver implementation. 34 // sync_driver::SyncServiceObserver implementation.
36 void OnStateChanged() override; 35 void OnStateChanged() override;
37 36
38 // StatusChangeChecker implementations and stubs. 37 // StatusChangeChecker implementations and stubs.
39 bool IsExitConditionSatisfied() override = 0; 38 bool IsExitConditionSatisfied() override = 0;
40 std::string GetDebugMessage() const override = 0; 39 std::string GetDebugMessage() const override = 0;
41 40
42 protected: 41 protected:
43 const std::vector<browser_sync::ProfileSyncService*>& services() { 42 const std::vector<browser_sync::ProfileSyncService*>& services() {
44 return services_; 43 return services_;
45 } 44 }
46 45
47 private: 46 private:
48 std::vector<browser_sync::ProfileSyncService*> services_; 47 std::vector<browser_sync::ProfileSyncService*> services_;
48 ScopedObserver<browser_sync::ProfileSyncService,
49 MultiClientStatusChangeChecker>
50 scoped_observer_;
49 }; 51 };
50 52
51 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECK ER_H_ 53 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_MULTI_CLIENT_STATUS_CHANGE_CHECK ER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698