chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc - Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc ('k') | chrome/browser/sync/test/integration/performance/dictionary_sync_perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc

diff --git a/chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc b/chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc

index e6f04cbbce2911e733c5e76812e142e6858f3000..782fd61dd41f8fd766c157b07a017117cc8a0dac 100644

--- a/chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc

+++ b/chrome/browser/sync/test/integration/performance/bookmarks_sync_perf_test.cc

@@ -16,6 +16,8 @@ using bookmarks_helper::IndexedURL;

using bookmarks_helper::IndexedURLTitle;

using bookmarks_helper::Remove;

using bookmarks_helper::SetURL;

+using sync_timing_helper::PrintResult;

+using sync_timing_helper::TimeMutualSyncCycle;

static const int kNumBookmarks = 150;

@@ -90,20 +92,19 @@ IN_PROC_BROWSER_TEST_F(BookmarksSyncPerfTest, P0) {

// TCM ID - 7556828.

AddURLs(0, kNumBookmarks);

- base::TimeDelta dt =

- SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));

+ base::TimeDelta dt = TimeMutualSyncCycle(GetClient(0), GetClient(1));

ASSERT_EQ(kNumBookmarks, GetURLCount(1));

- SyncTimingHelper::PrintResult("bookmarks", "add_bookmarks", dt);

+ PrintResult("bookmarks", "add_bookmarks", dt);

// TCM ID - 7564762.

UpdateURLs(0);

- dt = SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));

+ dt = TimeMutualSyncCycle(GetClient(0), GetClient(1));

ASSERT_EQ(kNumBookmarks, GetURLCount(1));

- SyncTimingHelper::PrintResult("bookmarks", "update_bookmarks", dt);

+ PrintResult("bookmarks", "update_bookmarks", dt);

// TCM ID - 7566626.

RemoveURLs(0);

- dt = SyncTimingHelper::TimeMutualSyncCycle(GetClient(0), GetClient(1));

+ dt = TimeMutualSyncCycle(GetClient(0), GetClient(1));

ASSERT_EQ(0, GetURLCount(1));

- SyncTimingHelper::PrintResult("bookmarks", "delete_bookmarks", dt);

+ PrintResult("bookmarks", "delete_bookmarks", dt);

}