Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7120)

Unified Diff: chrome/browser/sync/test/integration/fake_server_match_status_checker.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/fake_server_match_status_checker.cc
diff --git a/chrome/browser/sync/test/integration/fake_server_match_status_checker.cc b/chrome/browser/sync/test/integration/fake_server_match_status_checker.cc
index d45b01dbd44bcb84f462a6888c3a4ab4a3e7aac9..abba44e8dd169ec773d0b8b2aed35810d7a3fd52 100644
--- a/chrome/browser/sync/test/integration/fake_server_match_status_checker.cc
+++ b/chrome/browser/sync/test/integration/fake_server_match_status_checker.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "chrome/browser/sync/test/integration/fake_server_match_status_checker.h"
+
#include "chrome/browser/sync/test/integration/sync_datatype_helper.h"
#include "chrome/browser/sync/test/integration/sync_test.h"
@@ -11,18 +12,10 @@ namespace fake_server {
FakeServerMatchStatusChecker::FakeServerMatchStatusChecker()
: fake_server_(sync_datatype_helper::test()->GetFakeServer()) {
DCHECK(fake_server_);
+ fake_server_->AddObserver(this);
}
-void FakeServerMatchStatusChecker::Wait() {
- DVLOG(1) << "Await: " << GetDebugMessage();
-
- if (IsExitConditionSatisfied()) {
- DVLOG(1) << "Await -> Exit before waiting: " << GetDebugMessage();
- return;
- }
-
- fake_server_->AddObserver(this);
- StartBlockingWait();
+FakeServerMatchStatusChecker::~FakeServerMatchStatusChecker() {
fake_server_->RemoveObserver(this);
}

Powered by Google App Engine
This is Rietveld 408576698