Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/sync/test/integration/updated_progress_marker_checker.h

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_UPDATED_PROGRESS_MARKER_CHECKER_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_UPDATED_PROGRESS_MARKER_CHECKER_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_UPDATED_PROGRESS_MARKER_CHECKER_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_UPDATED_PROGRESS_MARKER_CHECKER_H_
7 7
8 #include <string>
9
8 #include "chrome/browser/sync/test/integration/single_client_status_change_check er.h" 10 #include "chrome/browser/sync/test/integration/single_client_status_change_check er.h"
9 11
10 // Waits until the latest progress markers are available. 12 // Waits until the latest progress markers are available.
11 // 13 //
12 // There are several limitations to this checker: 14 // There are several limitations to this checker:
13 // - It assumes that this client is the only one committing at this time. 15 // - It assumes that this client is the only one committing at this time.
14 // - It relies on the test-only 'self-notify' to trigger an extra GetUpdate 16 // - It relies on the test-only 'self-notify' to trigger an extra GetUpdate
15 // cycle after every commit. 17 // cycle after every commit.
16 // - It's flaky. In some rare cases, the IsExitConditionSatisifed() call could 18 // - It's flaky. In some rare cases, the IsExitConditionSatisifed() call could
17 // return a false positive. See comments in the .cc file for details. 19 // return a false positive. See comments in the .cc file for details.
18 // 20 //
19 // Because of these limitations, we intend to eventually migrate all tests off 21 // Because of these limitations, we intend to eventually migrate all tests off
20 // of this checker. Please do not use it in new tests. 22 // of this checker. Please do not use it in new tests.
21 class UpdatedProgressMarkerChecker : public SingleClientStatusChangeChecker { 23 class UpdatedProgressMarkerChecker : public SingleClientStatusChangeChecker {
22 public: 24 public:
23 explicit UpdatedProgressMarkerChecker( 25 explicit UpdatedProgressMarkerChecker(
24 browser_sync::ProfileSyncService* service); 26 browser_sync::ProfileSyncService* service);
25 ~UpdatedProgressMarkerChecker() override;
26 27
28 // StatusChangeChecker implementation.
27 bool IsExitConditionSatisfied() override; 29 bool IsExitConditionSatisfied() override;
28 std::string GetDebugMessage() const override; 30 std::string GetDebugMessage() const override;
29 }; 31 };
30 32
31 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_UPDATED_PROGRESS_MARKER_CHECKER_ H_ 33 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_UPDATED_PROGRESS_MARKER_CHECKER_ H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698