chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc - Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/single_client_apps_sync_test.cc ('k') | chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc b/chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc

index 215e7337434f712b7caf38208465f35d6ddf6e65..7f948b2d5c8292ec9b60ed8dbeb7cf0fc7017db5 100644

--- a/chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_arc_package_sync_test.cc

@@ -4,12 +4,10 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/sync/test/integration/sync_arc_package_helper.h"

-#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"

#include "chrome/browser/sync/test/integration/sync_test.h"

+#include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h"

#include "chrome/browser/ui/app_list/arc/arc_package_syncable_service.h"

-using sync_integration_test_util::AwaitCommitActivityCompletion;

namespace arc {

namespace {

@@ -68,7 +66,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientArcPackageSyncTest,

sync_helper()->InstallPackageWithIndex(verifier(), i);

}

- ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0)));

+ ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());

ASSERT_TRUE(AllProfilesHaveSameArcPackageDetails());

}