Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: chrome/browser/sync/test/integration/single_client_passwords_sync_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "chrome/browser/sync/test/integration/passwords_helper.h" 6 #include "chrome/browser/sync/test/integration/passwords_helper.h"
7 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 7 #include "chrome/browser/sync/test/integration/sync_test.h"
8 #include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h "
9 #include "components/browser_sync/profile_sync_service.h" 9 #include "components/browser_sync/profile_sync_service.h"
10 #include "components/password_manager/core/browser/password_manager_test_utils.h " 10 #include "components/password_manager/core/browser/password_manager_test_utils.h "
11 11
12 using passwords_helper::AddLogin; 12 using passwords_helper::AddLogin;
13 using passwords_helper::CreateTestPasswordForm; 13 using passwords_helper::CreateTestPasswordForm;
14 using passwords_helper::GetPasswordCount; 14 using passwords_helper::GetPasswordCount;
15 using passwords_helper::GetPasswordStore; 15 using passwords_helper::GetPasswordStore;
16 using passwords_helper::GetVerifierPasswordCount; 16 using passwords_helper::GetVerifierPasswordCount;
17 using passwords_helper::GetVerifierPasswordStore; 17 using passwords_helper::GetVerifierPasswordStore;
18 using passwords_helper::ProfileContainsSamePasswordFormsAsVerifier; 18 using passwords_helper::ProfileContainsSamePasswordFormsAsVerifier;
19 using sync_integration_test_util::AwaitCommitActivityCompletion;
20 19
21 using autofill::PasswordForm; 20 using autofill::PasswordForm;
22 21
23 class SingleClientPasswordsSyncTest : public SyncTest { 22 class SingleClientPasswordsSyncTest : public SyncTest {
24 public: 23 public:
25 SingleClientPasswordsSyncTest() : SyncTest(SINGLE_CLIENT) {} 24 SingleClientPasswordsSyncTest() : SyncTest(SINGLE_CLIENT) {}
26 ~SingleClientPasswordsSyncTest() override {} 25 ~SingleClientPasswordsSyncTest() override {}
27 26
28 private: 27 private:
29 DISALLOW_COPY_AND_ASSIGN(SingleClientPasswordsSyncTest); 28 DISALLOW_COPY_AND_ASSIGN(SingleClientPasswordsSyncTest);
30 }; 29 };
31 30
32 IN_PROC_BROWSER_TEST_F(SingleClientPasswordsSyncTest, Sanity) { 31 IN_PROC_BROWSER_TEST_F(SingleClientPasswordsSyncTest, Sanity) {
33 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 32 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
34 33
35 PasswordForm form = CreateTestPasswordForm(0); 34 PasswordForm form = CreateTestPasswordForm(0);
36 AddLogin(GetVerifierPasswordStore(), form); 35 AddLogin(GetVerifierPasswordStore(), form);
37 ASSERT_EQ(1, GetVerifierPasswordCount()); 36 ASSERT_EQ(1, GetVerifierPasswordCount());
38 AddLogin(GetPasswordStore(0), form); 37 AddLogin(GetPasswordStore(0), form);
39 ASSERT_EQ(1, GetPasswordCount(0)); 38 ASSERT_EQ(1, GetPasswordCount(0));
40 39
41 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0))); 40 ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
42 ASSERT_TRUE(ProfileContainsSamePasswordFormsAsVerifier(0)); 41 ASSERT_TRUE(ProfileContainsSamePasswordFormsAsVerifier(0));
43 ASSERT_EQ(1, GetPasswordCount(0)); 42 ASSERT_EQ(1, GetPasswordCount(0));
44 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698