Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: chrome/browser/sync/test/integration/single_client_dictionary_sync_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "chrome/browser/sync/test/integration/dictionary_helper.h" 6 #include "chrome/browser/sync/test/integration/dictionary_helper.h"
7 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
8 #include "chrome/browser/sync/test/integration/sync_test.h" 7 #include "chrome/browser/sync/test/integration/sync_test.h"
8 #include "chrome/browser/sync/test/integration/updated_progress_marker_checker.h "
9 #include "components/browser_sync/profile_sync_service.h" 9 #include "components/browser_sync/profile_sync_service.h"
10 10
11 using sync_integration_test_util::AwaitCommitActivityCompletion;
12
13 class SingleClientDictionarySyncTest : public SyncTest { 11 class SingleClientDictionarySyncTest : public SyncTest {
14 public: 12 public:
15 SingleClientDictionarySyncTest() : SyncTest(SINGLE_CLIENT) {} 13 SingleClientDictionarySyncTest() : SyncTest(SINGLE_CLIENT) {}
16 ~SingleClientDictionarySyncTest() override {} 14 ~SingleClientDictionarySyncTest() override {}
17 15
18 private: 16 private:
19 DISALLOW_COPY_AND_ASSIGN(SingleClientDictionarySyncTest); 17 DISALLOW_COPY_AND_ASSIGN(SingleClientDictionarySyncTest);
20 }; 18 };
21 19
22 IN_PROC_BROWSER_TEST_F(SingleClientDictionarySyncTest, Sanity) { 20 IN_PROC_BROWSER_TEST_F(SingleClientDictionarySyncTest, Sanity) {
23 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 21 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
24 dictionary_helper::LoadDictionaries(); 22 dictionary_helper::LoadDictionaries();
25 ASSERT_TRUE(dictionary_helper::DictionariesMatch()); 23 ASSERT_TRUE(dictionary_helper::DictionariesMatch());
26 24
27 std::string word = "foo"; 25 std::string word = "foo";
28 ASSERT_TRUE(dictionary_helper::AddWord(0, word)); 26 ASSERT_TRUE(dictionary_helper::AddWord(0, word));
29 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0))); 27 ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
30 ASSERT_TRUE(dictionary_helper::DictionariesMatch()); 28 ASSERT_TRUE(dictionary_helper::DictionariesMatch());
31 29
32 ASSERT_TRUE(dictionary_helper::RemoveWord(0, word)); 30 ASSERT_TRUE(dictionary_helper::RemoveWord(0, word));
33 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService(0))); 31 ASSERT_TRUE(UpdatedProgressMarkerChecker(GetSyncService(0)).Wait());
34 ASSERT_TRUE(dictionary_helper::DictionariesMatch()); 32 ASSERT_TRUE(dictionary_helper::DictionariesMatch());
35 } 33 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698