Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4241)

Unified Diff: chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc

Issue 2379433002: [Sync] Refactoring of sync integration test checkers to remove boilerplate await methods. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc b/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
index 5af034cd1272bb37ea46f4140ae9386d507ff854..3561ee5889823e18084268b4ea5a3e510a4a7737 100644
--- a/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
+++ b/chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc
@@ -15,7 +15,6 @@
#include "chrome/browser/sync/test/integration/sync_test.h"
#include "components/sync/engine/cycle/sync_cycle_snapshot.h"
-using sessions_helper::AwaitCheckForeignSessionsAgainst;
using sessions_helper::CheckInitialState;
using sessions_helper::DeleteForeignSession;
using sessions_helper::GetLocalWindows;
@@ -71,7 +70,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientSessionsSyncTest,
expected_windows[0] = std::move(client0_windows);
// Check the foreign windows on client 1
- ASSERT_TRUE(AwaitCheckForeignSessionsAgainst(1, expected_windows));
+ ASSERT_TRUE(ForeignSessionsMatchChecker(1, expected_windows).Wait());
}
IN_PROC_BROWSER_TEST_F(TwoClientSessionsSyncTest,
@@ -91,7 +90,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientSessionsSyncTest,
// Get foreign session data from all clients and check it against all
// client_windows.
for (int i = 0; i < num_clients(); ++i) {
- ASSERT_TRUE(AwaitCheckForeignSessionsAgainst(i, client_windows));
+ ASSERT_TRUE(ForeignSessionsMatchChecker(i, client_windows).Wait());
}
}

Powered by Google App Engine
This is Rietveld 408576698