Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, haraken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, timvolodine, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, Eric Willigers, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: explicitly differentiate ints vs doubles in the protocol bindings. BUG=628389 Committed: https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6 Cr-Commit-Position: refs/heads/master@{#405639}

Patch Set 1 #

Patch Set 2 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -152 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/LayoutEditor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp View 1 9 chunks +37 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16STL.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.h View 1 5 chunks +15 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Values.cpp View 1 5 chunks +58 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 11 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 1 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pfeldman
4 years, 5 months ago (2016-07-14 22:10:55 UTC) #3
alph
lgtm
4 years, 5 months ago (2016-07-14 23:12:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2151083002/20001
4 years, 5 months ago (2016-07-14 23:49:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 23:55:36 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:57:57 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/33055dd442b76878063eff2385a27eb7604fbae6
Cr-Commit-Position: refs/heads/master@{#405639}

Powered by Google App Engine
This is Rietveld 408576698