Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: lcean Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
6 6
7 #include "platform/v8_inspector/V8ConsoleMessage.h" 7 #include "platform/v8_inspector/V8ConsoleMessage.h"
8 #include "platform/v8_inspector/V8DebuggerImpl.h" 8 #include "platform/v8_inspector/V8DebuggerImpl.h"
9 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 9 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
10 #include "platform/v8_inspector/V8StackTraceImpl.h" 10 #include "platform/v8_inspector/V8StackTraceImpl.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 return m_enabled; 70 return m_enabled;
71 } 71 }
72 72
73 void V8ConsoleAgentImpl::reportAllMessages() 73 void V8ConsoleAgentImpl::reportAllMessages()
74 { 74 {
75 V8ConsoleMessageStorage* storage = m_session->debugger()->ensureConsoleMessa geStorage(m_session->contextGroupId()); 75 V8ConsoleMessageStorage* storage = m_session->debugger()->ensureConsoleMessa geStorage(m_session->contextGroupId());
76 if (storage->expiredCount()) { 76 if (storage->expiredCount()) {
77 std::unique_ptr<protocol::Console::ConsoleMessage> expired = protocol::C onsole::ConsoleMessage::create() 77 std::unique_ptr<protocol::Console::ConsoleMessage> expired = protocol::C onsole::ConsoleMessage::create()
78 .setSource(protocol::Console::ConsoleMessage::SourceEnum::Other) 78 .setSource(protocol::Console::ConsoleMessage::SourceEnum::Other)
79 .setLevel(protocol::Console::ConsoleMessage::LevelEnum::Warning) 79 .setLevel(protocol::Console::ConsoleMessage::LevelEnum::Warning)
80 .setText(String16::number(storage->expiredCount()) + String16("conso le messages are not shown.")) 80 .setText(String16::fromInteger(storage->expiredCount()) + String16(" console messages are not shown."))
81 .setTimestamp(0) 81 .setTimestamp(0)
82 .build(); 82 .build();
83 expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log); 83 expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log);
84 expired->setLine(0); 84 expired->setLine(0);
85 expired->setColumn(0); 85 expired->setColumn(0);
86 expired->setUrl(""); 86 expired->setUrl("");
87 m_frontend.messageAdded(std::move(expired)); 87 m_frontend.messageAdded(std::move(expired));
88 m_frontend.flush(); 88 m_frontend.flush();
89 } 89 }
90 for (const auto& message : storage->messages()) { 90 for (const auto& message : storage->messages()) {
91 if (message->origin() == V8MessageOrigin::kConsole) 91 if (message->origin() == V8MessageOrigin::kConsole)
92 reportMessage(message.get(), false); 92 reportMessage(message.get(), false);
93 } 93 }
94 } 94 }
95 95
96 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review) 96 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review)
97 { 97 {
98 DCHECK_EQ(V8MessageOrigin::kConsole, message->origin()); 98 DCHECK_EQ(V8MessageOrigin::kConsole, message->origin());
99 message->reportToFrontend(&m_frontend, m_session, generatePreview); 99 message->reportToFrontend(&m_frontend, m_session, generatePreview);
100 m_frontend.flush(); 100 m_frontend.flush();
101 } 101 }
102 102
103 } // namespace blink 103 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698