third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/LayoutEditor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

index fdaecbec8f810feb6f5b7e9c05154ab0c1a1b13c..068317a6a778a96ec851406646925dd0ff5a4a78 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp

@@ -349,7 +349,7 @@ void InspectorPageAgent::restore()

ErrorString error;

if (m_state->booleanProperty(PageAgentState::pageAgentEnabled, false))

enable(&error);

- setBlockedEventsWarningThreshold(&error, m_state->numberProperty(PageAgentState::blockedEventsWarningThreshold, 0.0));

+ setBlockedEventsWarningThreshold(&error, m_state->doubleProperty(PageAgentState::blockedEventsWarningThreshold, 0.0));

}

void InspectorPageAgent::enable(ErrorString*)

@@ -750,7 +750,7 @@ void InspectorPageAgent::setOverlayMessage(ErrorString*, const Maybe<String>& me

void InspectorPageAgent::setBlockedEventsWarningThreshold(ErrorString*, double threshold)

{

- m_state->setNumber(PageAgentState::blockedEventsWarningThreshold, threshold);

+ m_state->setDouble(PageAgentState::blockedEventsWarningThreshold, threshold);

FrameHost* host = m_inspectedFrames->root()->host();

if (!host)

return;