third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

index e7fb57a0baa048ecb00a82f44cbf68c4dcc60aad..343234c02278ccd8a02de1f8bb3d5461bc96a395 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

@@ -26,7 +26,7 @@ static const v8::StackTrace::StackTraceOptions stackTraceOptions = static_cast<v

V8StackTraceImpl::Frame toFrame(v8::Local<v8::StackFrame> frame)

{

- String16 scriptId = String16::number(frame->GetScriptId());

+ String16 scriptId = String16::fromInteger(frame->GetScriptId());

String16 sourceName;

v8::Local<v8::String> sourceNameValue(frame->GetScriptNameOrSourceURL());

if (!sourceNameValue.IsEmpty())