third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

index b452fa9eb1c536607e3686fbd43903cc88af1a47..b8d116a87b2641003ca8acc48edced92cf29dffe 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

@@ -354,7 +354,7 @@ void V8Console::countCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

if (title.isEmpty()) {

std::unique_ptr<V8StackTraceImpl> stackTrace = V8StackTraceImpl::capture(nullptr, 0, 1);

if (stackTrace)

- identifier = stackTrace->topSourceURL() + ":" + String16::number(stackTrace->topLineNumber());

+ identifier = stackTrace->topSourceURL() + ":" + String16::fromInteger(stackTrace->topLineNumber());

} else {

identifier = title + "@";

}

@@ -364,7 +364,7 @@ void V8Console::countCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

return;

int64_t count = helper.getIntFromMap(countMap, identifier, 0) + 1;

helper.setIntOnMap(countMap, identifier, count);

- helper.addMessage(ConsoleAPIType::kCount, DebugMessageLevel, title + ": " + String16::number(count));

+ helper.addMessage(ConsoleAPIType::kCount, DebugMessageLevel, title + ": " + String16::fromInteger(count));

}

void V8Console::assertCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

@@ -522,7 +522,7 @@ static void setFunctionBreakpoint(ConsoleHelper& helper, v8::Local<v8::Function>

V8DebuggerAgentImpl* debuggerAgent = helper.debuggerAgent();

if (!debuggerAgent)

return;

- String16 scriptId = String16::number(function->ScriptId());

+ String16 scriptId = String16::fromInteger(function->ScriptId());

int lineNumber = function->GetScriptLineNumber();

int columnNumber = function->GetScriptColumnNumber();

if (lineNumber == v8::Function::kLineOffsetNotFound || columnNumber == v8::Function::kLineOffsetNotFound)