third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

index 57e91e82c03303b79e305a6043b83dec05190c19..100dd6adfc920ed52d5031b8ea6a48ca9dfbe491 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

@@ -499,7 +499,7 @@ void V8DebuggerImpl::handleProgramBreak(v8::Local<v8::Context> pausedContext, v8

for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++) {

v8::Local<v8::Value> hitBreakpointNumber = hitBreakpointNumbers->Get(i);

DCHECK(!hitBreakpointNumber.IsEmpty() && hitBreakpointNumber->IsInt32());

- breakpointIds.push_back(String16::number(hitBreakpointNumber->Int32Value()));

+ breakpointIds.push_back(String16::fromInteger(hitBreakpointNumber->Int32Value()));

}

@@ -754,7 +754,7 @@ v8::Local<v8::Value> V8DebuggerImpl::functionLocation(v8::Local<v8::Context> con

if (lineNumber == v8::Function::kLineOffsetNotFound || columnNumber == v8::Function::kLineOffsetNotFound)

return v8::Null(m_isolate);

v8::Local<v8::Object> location = v8::Object::New(m_isolate);

- if (!location->Set(context, v8InternalizedString("scriptId"), toV8String(m_isolate, String16::number(scriptId))).FromMaybe(false))

+ if (!location->Set(context, v8InternalizedString("scriptId"), toV8String(m_isolate, String16::fromInteger(scriptId))).FromMaybe(false))

return v8::Null(m_isolate);

if (!location->Set(context, v8InternalizedString("lineNumber"), v8::Integer::New(m_isolate, lineNumber)).FromMaybe(false))

return v8::Null(m_isolate);

@@ -893,7 +893,7 @@ void V8DebuggerImpl::contextCreated(const V8ContextInfo& info)

DCHECK(info.context->GetIsolate() == m_isolate);

// TODO(dgozman): make s_lastContextId non-static.

int contextId = atomicIncrement(&s_lastContextId);

- String16 debugData = String16::number(info.contextGroupId) + "," + String16::number(contextId) + "," + (info.isDefault ? "default" : "nondefault");

+ String16 debugData = String16::fromInteger(info.contextGroupId) + "," + String16::fromInteger(contextId) + "," + (info.isDefault ? "default" : "nondefault");

v8::HandleScope scope(m_isolate);

v8::Context::Scope contextScope(info.context);

info.context->SetEmbedderData(static_cast<int>(v8::Context::kDebugIdIndex), toV8String(m_isolate, debugData));