third_party/WebKit/Source/platform/inspector_protocol/String16STL.h - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/String16STL.h

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/String16STL.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h b/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h

index e86c4059565c665ea3e11140fdfe37c9f28b715c..cdd183177f7feab1f22fc446963c0b510109c908 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/String16STL.h

@@ -42,7 +42,7 @@ public:

const UChar* characters16() const { return m_impl.c_str(); }

std::string utf8() const;

static String16 fromUTF8(const char* stringStart, size_t length);

- static String16 number(int i) { return String16(String16::intToString(i).c_str()); }

+ static String16 fromInteger(int i) { return String16(String16::intToString(i).c_str()); }

static String16 fromDouble(double d) { return String16(String16::doubleToString(d).c_str()); }

static String16 fromDoubleFixedPrecision(double d, int len) { return String16(String16::doubleToString(d).c_str()); }

@@ -170,7 +170,7 @@ public:

void appendNumber(int i)

{

- m_impl = m_impl + String16::number(i).impl();

+ m_impl = m_impl + String16::fromInteger(i).impl();

}

void appendNumber(double d)