third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h b/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h

index df72ed8414f88c56c41cac54026cd3db182c39f5..dd7b2e786410549f7a9010a8349f32e61883d9c7 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h

@@ -64,7 +64,7 @@ struct FromValue<int> {

static int parse(protocol::Value* value, ErrorSupport* errors)

{

int result = 0;

- bool success = value ? value->asNumber(&result) : false;

+ bool success = value ? value->asInteger(&result) : false;

if (!success)

errors->addError("integer value expected");

return result;

@@ -76,7 +76,7 @@ struct FromValue<double> {

static double parse(protocol::Value* value, ErrorSupport* errors)

{

double result = 0;

- bool success = value ? value->asNumber(&result) : false;

+ bool success = value ? value->asDouble(&result) : false;

if (!success)

errors->addError("double value expected");

return result;