third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/LayoutEditor.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/Array.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

index b42a6ada5d96a687b06d217d020605e41cf5bba5..03541bad6e67423b864ee5db62c820ac6ef320f3 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

@@ -49,9 +49,9 @@ DeviceOrientationController& DeviceOrientationInspectorAgent::controller()

void DeviceOrientationInspectorAgent::setDeviceOrientationOverride(ErrorString* error, double alpha, double beta, double gamma)

{

m_state->setBoolean(DeviceOrientationInspectorAgentState::overrideEnabled, true);

- m_state->setNumber(DeviceOrientationInspectorAgentState::alpha, alpha);

- m_state->setNumber(DeviceOrientationInspectorAgentState::beta, beta);

- m_state->setNumber(DeviceOrientationInspectorAgentState::gamma, gamma);

+ m_state->setDouble(DeviceOrientationInspectorAgentState::alpha, alpha);

+ m_state->setDouble(DeviceOrientationInspectorAgentState::beta, beta);

+ m_state->setDouble(DeviceOrientationInspectorAgentState::gamma, gamma);

controller().setOverride(DeviceOrientationData::create(alpha, beta, gamma, false));

}

@@ -71,11 +71,11 @@ void DeviceOrientationInspectorAgent::restore()

{

if (m_state->booleanProperty(DeviceOrientationInspectorAgentState::overrideEnabled, false)) {

double alpha = 0;

- m_state->getNumber(DeviceOrientationInspectorAgentState::alpha, &alpha);

+ m_state->getDouble(DeviceOrientationInspectorAgentState::alpha, &alpha);

double beta = 0;

- m_state->getNumber(DeviceOrientationInspectorAgentState::beta, &beta);

+ m_state->getDouble(DeviceOrientationInspectorAgentState::beta, &beta);

double gamma = 0;

- m_state->getNumber(DeviceOrientationInspectorAgentState::gamma, &gamma);

+ m_state->getDouble(DeviceOrientationInspectorAgentState::gamma, &gamma);

controller().setOverride(DeviceOrientationData::create(alpha, beta, gamma, false));

}