third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

index 6e85210c014af0e02ee26982e046c4946485005c..74eaf08e2e4aac30b8e287a18e0bef4f7464e1e3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

@@ -77,7 +77,7 @@ void V8ConsoleAgentImpl::reportAllMessages()

std::unique_ptr<protocol::Console::ConsoleMessage> expired = protocol::Console::ConsoleMessage::create()

.setSource(protocol::Console::ConsoleMessage::SourceEnum::Other)

.setLevel(protocol::Console::ConsoleMessage::LevelEnum::Warning)

- .setText(String16::number(storage->expiredCount()) + String16("console messages are not shown."))

+ .setText(String16::fromInteger(storage->expiredCount()) + String16("console messages are not shown."))

.setTimestamp(0)

.build();

expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log);