third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

index 66a2d9f16dcb5dc7ecbff0d04c1aea0201792e3d..d6a02283c505438b6366882c83bbb88e33e24e60 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

@@ -243,7 +243,7 @@ void V8ConsoleMessage::reportToFrontend(protocol::Console::Frontend* frontend, V

result->setLine(static_cast<int>(m_lineNumber));

result->setColumn(static_cast<int>(m_columnNumber));

if (m_scriptId)

- result->setScriptId(String16::number(m_scriptId));

+ result->setScriptId(String16::fromInteger(m_scriptId));

result->setUrl(m_url);

if (m_source == NetworkMessageSource && !m_requestIdentifier.isEmpty())

result->setNetworkRequestId(m_requestIdentifier);

@@ -304,7 +304,7 @@ void V8ConsoleMessage::reportToFrontend(protocol::Runtime::Frontend* frontend, V

if (m_columnNumber)

details->setColumnNumber(static_cast<int>(m_columnNumber) - 1);

if (m_scriptId)

- details->setScriptId(String16::number(m_scriptId));

+ details->setScriptId(String16::fromInteger(m_scriptId));

if (m_stackTrace)

details->setStack(m_stackTrace->buildInspectorObject());