third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Values.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

index c985e9daefb20fb6ff4821ab8520003a7dcd91f4..8a1402974fdef4a478388df20bc7548789db7472 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

@@ -146,7 +146,7 @@ void InjectedScript::releaseObject(const String16& objectId)

if (!object)

return;

int boundId = 0;

- if (!object->getNumber("id", &boundId))

+ if (!object->getInteger("id", &boundId))

return;

m_native->unbind(boundId);

}

@@ -309,7 +309,7 @@ std::unique_ptr<protocol::Runtime::ExceptionDetails> InjectedScript::createExcep

{

std::unique_ptr<protocol::Runtime::ExceptionDetails> exceptionDetailsObject = protocol::Runtime::ExceptionDetails::create().setText(toProtocolString(message->Get())).build();

exceptionDetailsObject->setUrl(toProtocolStringWithTypeCheck(message->GetScriptResourceName()));

- exceptionDetailsObject->setScriptId(String16::number(message->GetScriptOrigin().ScriptID()->Value()));

+ exceptionDetailsObject->setScriptId(String16::fromInteger(message->GetScriptOrigin().ScriptID()->Value()));

v8::Maybe<int> lineNumber = message->GetLineNumber(m_context->context());

if (lineNumber.IsJust())