third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

index 3df4c330b6111f85c456c3c371d81865996e15fd..1856656ed0fb9f2696f0900ed29e97d12a7e229f 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

@@ -274,8 +274,8 @@ void InspectorNetworkAgent::restore()

{

if (m_state->booleanProperty(NetworkAgentState::networkAgentEnabled, false)) {

enable(

- m_state->numberProperty(NetworkAgentState::totalBufferSize, maximumTotalBufferSize),

- m_state->numberProperty(NetworkAgentState::resourceBufferSize, maximumResourceBufferSize));

+ m_state->integerProperty(NetworkAgentState::totalBufferSize, maximumTotalBufferSize),

+ m_state->integerProperty(NetworkAgentState::resourceBufferSize, maximumResourceBufferSize));

}

@@ -937,8 +937,8 @@ void InspectorNetworkAgent::enable(int totalBufferSize, int resourceBufferSize)

return;

m_resourcesData->setResourcesDataSizeLimits(totalBufferSize, resourceBufferSize);

m_state->setBoolean(NetworkAgentState::networkAgentEnabled, true);

- m_state->setNumber(NetworkAgentState::totalBufferSize, totalBufferSize);

- m_state->setNumber(NetworkAgentState::resourceBufferSize, resourceBufferSize);

+ m_state->setInteger(NetworkAgentState::totalBufferSize, totalBufferSize);

+ m_state->setInteger(NetworkAgentState::resourceBufferSize, resourceBufferSize);

m_instrumentingAgents->addInspectorNetworkAgent(this);

}